From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8D5E96ECE3; Wed, 29 Jun 2022 11:09:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8D5E96ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656490181; bh=1gVriJochcysYRnRIppbw7+X+VTY9S/Tz7xbLn36kgE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SUVLa/3ZYAgZjJxLik8JbQmY/l3D1kb/Bo1Ag0rwYdKKBMKXPJhkKNkPwF3afMynW H+TDitYLknouBBUzRlM/bv50YpkyxW8xiqdAwVhORIpWNfIbnPzhd1dEyvtGp8cYU9 pzqxN37POu6jEJ/PaQiZhBeMiFvcZmMmWq2P5kdk= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5A7396ECE3 for ; Wed, 29 Jun 2022 11:09:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5A7396ECE3 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1o6SlX-00058Y-FH; Wed, 29 Jun 2022 11:09:39 +0300 Date: Wed, 29 Jun 2022 11:02:29 +0300 To: Sergey Kaplun Message-ID: References: <20220506045339.8919-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220506045339.8919-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD921FF253C2DCA64328D82274A16F3B1206881FAF42C11B61F00894C459B0CD1B94E564CC9A7A19F27402EED7DF394357E7C386553935B561EBD50C9D6CC5BE988 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75C385DEB91CEC222EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375A514678F9DF65078638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AABEB0053BB9ED8F736451DA9DD441A1117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86DC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6D635BA3ABDB36C18089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A52052E9DC28831059E94CE967A2ED6EB12C06008DB235A629D59269BC5F550898D99A6476B3ADF6B4886A5961035A09600383DAD389E261318FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3450C5E6D685282BA16146B71AD6ED684E01995CE7FA2411978E0B65706557DBCCD698415E8EC442301D7E09C32AA3244CE43CD13AC325DBE0ACDBB64B9106F42A3A92A9747B6CC886927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojX1xomQseBkU4hvmScoid1Q== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E755D49FCBBEA5D83A3FBCF45C59F4565A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Handle zero-fill of struct-of-NYI. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, with a little tweak for commit message: | FFI: Handle zero-fill of struct-of-NYI. | | (cherry picked from ad65934fa08a65bfb0eb9528731a4394842cc173) | | Trace recording is aborted with NYI reason for the case of a struct with | aggregate allocation. The general solution is way too complex due to | heterogeneous initialization of the structure. However, zero-fill case | requires nothing but "memset"-like initialization of GCcdata payload. | | As a result of this patch workaround for the zero-fill structures is | introduced. | | Sergey Kaplun: | * added the description and the test for the problem | | Part of tarantool/tarantool#6548 | Related to tarantool/tarantool#4630 | Related to tarantool/tarantool#5885 -- Best regards, IM