From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: fix path storage for non-concatable objects
Date: Tue, 28 Jun 2022 18:41:18 +0300 [thread overview]
Message-ID: <YrshHnYfsbts8k5L@tarantool.org> (raw)
In-Reply-To: <0d207e1a15360109e1e9c4bb775248f0fc04edc6.1631170629.git.skaplun@tarantool.org>
Sergey,
Thanks for the patch! LGTM, as trivial. I've only made some tweaks in
commit message:
| test: fix path storage for non-concatable objects
|
| When a key of the table to be compared via `tap.test:is_deeply()` is a
| non-concatable object (i.e. lightuserdata) its concatenation with the
| path prefix raises an error. As a result of this patch the object is
| explicitly converted to string to avoid this error.
--
Best regards,
IM
next prev parent reply other threads:[~2022-06-28 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 7:03 [Tarantool-patches] [PATCH luajit 0/3] Follow-up fixes for full 64-bit lightuserdata interning Sergey Kaplun via Tarantool-patches
2021-09-09 7:03 ` [Tarantool-patches] [PATCH luajit 1/3] test: fix path storage for non-concatable objects Sergey Kaplun via Tarantool-patches
2021-09-15 15:30 ` sergos via Tarantool-patches
2021-09-20 8:28 ` Sergey Kaplun via Tarantool-patches
2021-09-20 9:37 ` sergos via Tarantool-patches
2022-06-28 15:41 ` Igor Munkin via Tarantool-patches [this message]
2021-09-09 7:03 ` [Tarantool-patches] [PATCH luajit 2/3] Reorganize lightuserdata interning code Sergey Kaplun via Tarantool-patches
2021-09-15 15:30 ` sergos via Tarantool-patches
2021-09-20 8:32 ` Sergey Kaplun via Tarantool-patches
2021-09-20 9:37 ` sergos via Tarantool-patches
2022-06-28 15:42 ` Igor Munkin via Tarantool-patches
2021-09-09 7:03 ` [Tarantool-patches] [PATCH luajit 3/3] Avoid conflict between 64 bit lightuserdata and ITERN key Sergey Kaplun via Tarantool-patches
2021-09-15 15:31 ` sergos via Tarantool-patches
2021-09-20 8:38 ` Sergey Kaplun via Tarantool-patches
2021-09-20 9:37 ` sergos via Tarantool-patches
2022-06-29 20:20 ` Igor Munkin via Tarantool-patches
2022-06-30 12:11 ` [Tarantool-patches] [PATCH luajit 0/3] Follow-up fixes for full 64-bit lightuserdata interning Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrshHnYfsbts8k5L@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/3] test: fix path storage for non-concatable objects' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox