From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Add missing LJ_MAX_JSLOTS check.
Date: Tue, 28 Jun 2022 09:39:37 +0300 [thread overview]
Message-ID: <YrqiKZG1+5/cmiTo@root> (raw)
In-Reply-To: <YroL6U3NPdkULOzS@tarantool.org>
Igor,
Thanks for the review and fixup, it LGTM.
On 27.06.22, Igor Munkin wrote:
> Sergey,
>
> Thanks for the patch! LGTM, but I've rewritten the test a bit to not run
> both tests for a single build. You can find the changes within this
> commit[1] and I proceed with the patch if you're OK with it.
>
> [1]: https://github.com/tarantool/luajit/commit/fe6d486
>
> --
> Best regards,
> IM
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2022-06-28 6:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 11:46 Sergey Kaplun via Tarantool-patches
2022-03-25 15:51 ` sergos via Tarantool-patches
2022-03-28 10:02 ` Sergey Kaplun via Tarantool-patches
2022-03-30 10:02 ` sergos via Tarantool-patches
2022-04-06 7:21 ` Sergey Kaplun via Tarantool-patches
2022-06-27 19:58 ` Igor Munkin via Tarantool-patches
2022-06-28 6:39 ` Sergey Kaplun via Tarantool-patches [this message]
2022-06-30 12:08 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrqiKZG1+5/cmiTo@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] Add missing LJ_MAX_JSLOTS check.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox