Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Add stricter check for print() vs. tostring() shortcut.
Date: Thu, 23 Jun 2022 19:19:08 +0300	[thread overview]
Message-ID: <YrSSfJqes6as537O@tarantool.org> (raw)
In-Reply-To: <20211227102524.9410-1-skaplun@tarantool.org>

Sergey,

Thanks for the patch! In addition to Sergos' nits regarding the commit
message, I have two regarding the test:
  1. Why didn't you use <utils.selfrun> helper for your purposes? It
     fits better than the pack of hacks implementing quite a similar
     routine.
  2. Test name should start with the corresponding issue number from
     LuaJIT queue, AFAIR.

I fixed both comments within fixup commit on top of your branch[1].
Otherwise the patch LGTM, so if you're OK with the changes, I'll proceed
with it.

Last, but not least: I see no ChangeLog entry in the patch. Could you
please drop a few words regarding the change in this thread?

[1]: https://github.com/tarantool/luajit/commit/da9f089

-- 
Best regards,
IM

  parent reply	other threads:[~2022-06-23 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-27 10:25 Sergey Kaplun via Tarantool-patches
2022-06-06 15:54 ` sergos via Tarantool-patches
2022-06-15  7:00   ` Sergey Kaplun via Tarantool-patches
2022-06-23 16:19 ` Igor Munkin via Tarantool-patches [this message]
2022-06-30 12:09 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrSSfJqes6as537O@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] Add stricter check for print() vs. tostring() shortcut.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox