Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2] test: adapt test checking reversed function
Date: Mon, 20 Jun 2022 15:47:28 +0300	[thread overview]
Message-ID: <YrBsYMakmLMHLbq/@tarantool.org> (raw)
In-Reply-To: <20220228235445.1841219-1-m.kokryashkin@tarantool.org>

Max,

I've checked the patch into all long-term branches in tarantool/luajit
and bumped a new version in master, 2.10 and 1.10.

On 01.03.22, Maxim Kokryashkin wrote:
> The first fiber in Tarantool has only 512Kb of the stack, which is not enough
> to handle such a deep call chain. Thus, the chunk of code being considered
> cores with SIGSEGV as a result of C stack overflow.
> The test is adapted to Tarantool by decreasing the string length.
> 
> Resolves tarantool/tarantool#5782
> Part of tarantool/tarantool#5870
> ---
> Changes in v2:
> - Fixed comments as per review by Igor
> 
> GitHub branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-5782-adapt-deep-nest-gsub-PUC-Rio
> CI branch: https://github.com/tarantool/tarantool/tree/fckxorg/gh-5782-adapt-test-checking-reversed-function-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/5782
> 
>  test/PUC-Rio-Lua-5.1-tests/pm.lua | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 

<snipped>

> -- 
> 2.35.1
> 

-- 
Best regards,
IM

      parent reply	other threads:[~2022-06-20 12:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 23:54 Maxim Kokryashkin via Tarantool-patches
2022-03-02  5:59 ` Sergey Kaplun via Tarantool-patches
2022-06-01 14:31 ` Igor Munkin via Tarantool-patches
2022-06-20 12:47 ` Igor Munkin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrBsYMakmLMHLbq/@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --subject='Re: [Tarantool-patches] [PATCH luajit v2] test: adapt test checking reversed function' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox