From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tarantool-patches@dev.tarantool.org, imun@tarantool.org, skaplun@tarantool.org Subject: [Tarantool-patches] [PATCH luajit v2] test: adapt test checking reversed function Date: Tue, 1 Mar 2022 02:54:45 +0300 [thread overview] Message-ID: <20220228235445.1841219-1-m.kokryashkin@tarantool.org> (raw) The first fiber in Tarantool has only 512Kb of the stack, which is not enough to handle such a deep call chain. Thus, the chunk of code being considered cores with SIGSEGV as a result of C stack overflow. The test is adapted to Tarantool by decreasing the string length. Resolves tarantool/tarantool#5782 Part of tarantool/tarantool#5870 --- Changes in v2: - Fixed comments as per review by Igor GitHub branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-5782-adapt-deep-nest-gsub-PUC-Rio CI branch: https://github.com/tarantool/tarantool/tree/fckxorg/gh-5782-adapt-test-checking-reversed-function-full-ci Issue: https://github.com/tarantool/tarantool/issues/5782 test/PUC-Rio-Lua-5.1-tests/pm.lua | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/test/PUC-Rio-Lua-5.1-tests/pm.lua b/test/PUC-Rio-Lua-5.1-tests/pm.lua index e364ff9d..61f437f6 100644 --- a/test/PUC-Rio-Lua-5.1-tests/pm.lua +++ b/test/PUC-Rio-Lua-5.1-tests/pm.lua @@ -206,12 +206,16 @@ function rev (s) return string.gsub(s, "(.)(.+)", function (c,s1) return rev(s1)..c end) end -local x = string.rep('012345', 10) --- FIXME: The first Tarantool's fiber has only 512Kb of stack. --- It is not enough for this recursive call. +-- The first fiber in Tarantool has only 512Kb of the stack, +-- which is not enough to handle such a deep call chain. Thus, +-- the chunk of code being considered cores with SIGSEGV as a +-- result of C stack overflow. +-- +-- This test is adapted to match the stack size of the first fiber in +-- Tarantool by decreasing the string length. -- See also https://github.com/tarantool/tarantool/issues/5782. --- The test is disabled for Tarantool binary. --- assert(rev(rev(x)) == x) +local x = string.rep('01234', 10) +assert(rev(rev(x)) == x) -- gsub with tables -- 2.35.1
next reply other threads:[~2022-02-28 23:54 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-28 23:54 Maxim Kokryashkin via Tarantool-patches [this message] 2022-03-02 5:59 ` Sergey Kaplun via Tarantool-patches 2022-06-01 14:31 ` Igor Munkin via Tarantool-patches 2022-06-20 12:47 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220228235445.1841219-1-m.kokryashkin@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v2] test: adapt test checking reversed function' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox