From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Flush and close output file after profiling run.
Date: Thu, 30 Jun 2022 15:10:39 +0300 [thread overview]
Message-ID: <Yr2Sv6OFAEYitWpE@tarantool.org> (raw)
In-Reply-To: <20220512100937.24037-1-skaplun@tarantool.org>
Sergey,
I've checked the patch into all long-term branches in tarantool/luajit
and bumped a new version in master, 2.10 and 1.10.
On 12.05.22, Sergey Kaplun wrote:
> From: Mike Pall <mike>
>
> Thanks to Sergey Ostanevich.
>
> Using `jit.p` with a file argument does not flush result to the
> file on profile stop.
>
> This patch adds missing close for the file descriptor on profile stop.
>
> Sergey Kaplun:
> * added the description and the test for the problem
> ---
>
> LuaJIT PR: https://github.com/LuaJIT/LuaJIT/pull/726
> Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-726-profile-flush-close-full-ci
> Tarantool PR: https://github.com/tarantool/tarantool/pull/7128
>
> src/jit/p.lua | 1 +
> .../lj-726-profile-flush-close.test.lua | 29 +++++++++++++++++++
> 2 files changed, 30 insertions(+)
> create mode 100644 test/tarantool-tests/lj-726-profile-flush-close.test.lua
>
<snipped>
> --
> 2.34.1
>
--
Best regards,
IM
prev parent reply other threads:[~2022-06-30 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 10:09 Sergey Kaplun via Tarantool-patches
2022-06-21 13:50 ` sergos via Tarantool-patches
2022-06-28 23:57 ` Igor Munkin via Tarantool-patches
2022-06-30 12:10 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr2Sv6OFAEYitWpE@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] Flush and close output file after profiling run.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox