From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Fix debug.debug() for non-string errors. Date: Thu, 30 Jun 2022 15:10:11 +0300 [thread overview] Message-ID: <Yr2Sow4grdZvDkLd@tarantool.org> (raw) In-Reply-To: <20211230114513.23020-1-skaplun@tarantool.org> Sergey, I've checked the patch into all long-term branches in tarantool/luajit and bumped a new version in master, 2.10 and 1.10. On 30.12.21, Sergey Kaplun wrote: > From: Mike Pall <mike> > > (cherry picked from f5b0fff5a990004375ad43aa6e6c4a11a8b6eb7e) > > `lua_tostring()` returns NULL for non-string and non-number objects. > Returned value is passed to `fputs()` without check, so that leads to > crash in case of NULL. > > This patch adds the corresponding check. "(error object is not a > string)" is returned in the aforementioned case. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#6548 > --- > > Related issue: https://github.com/tarantool/tarantool/issues/6548 > Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-debug-debug-non-string-err > Tarantool branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-noticket-debug-debug-non-string-err-full-ci > > src/lib_debug.c | 3 ++- > .../debug-non-string-error.test.lua | 26 +++++++++++++++++++ > 2 files changed, 28 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/debug-non-string-error.test.lua > <snipped> > -- > 2.34.1 > -- Best regards, IM
prev parent reply other threads:[~2022-06-30 12:18 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-30 11:45 Sergey Kaplun via Tarantool-patches 2022-06-21 12:01 ` sergos via Tarantool-patches 2022-06-22 8:24 ` Sergey Kaplun via Tarantool-patches 2022-06-28 23:05 ` Igor Munkin via Tarantool-patches 2022-06-30 12:10 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yr2Sow4grdZvDkLd@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Fix debug.debug() for non-string errors.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox