From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 661776FC83; Thu, 30 Jun 2022 15:18:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 661776FC83 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656591531; bh=q6fYJr4oHWA+9Vn6LLn9sxYXAIsJy/SC8Ig/1Tr+fyU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=utRwdIQ6rX+Etb2vIq3JhYcnz9XSC2DZNztBIYJbXdBt0txxY/HY0zuA014WyfJ/c EmgA52HX5gPm0APhv4E7r96Tm9NFM0s97pfwpFPsc3qA9QQVYy0sXZ4wOSwW7uCIx9 urU6dRSGcqEhvt/uj+F2V/lD6j9bvML+sHDcXDm8= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3D3846DB0B for ; Thu, 30 Jun 2022 15:17:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3D3846DB0B Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1o6t6o-0000Uq-97; Thu, 30 Jun 2022 15:17:22 +0300 Date: Thu, 30 Jun 2022 15:10:11 +0300 To: Sergey Kaplun Message-ID: References: <20211230114513.23020-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211230114513.23020-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F05DDD76985F9126692D3D1FA89E748E12FC702E1748058B182A05F538085040EDA830191AEEE41283E9A4486C677BCB52F6D2721E5440653B2B4F0C98CFE8AB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A0569EA9A35E44F48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89A4C48CD9790958D22592C35C19C6F9E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B60A62CEF541B197C8089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1CF0FC9FF3B6FB18F822EFD966914D10B573505E26884B198CAD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3444047AE358B407541577C1AE6CEEE03551FBE749A8B1F7E0F11722A4AEB032899E9E1CAFB2CC86641D7E09C32AA3244C41EE8A5E671F2FB725457D7A029D02E7F94338140B71B8EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhvrbUd41KJlxa2ccDV/pZw== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284ECBEE5E0E1ABB1088E0559078138BEB6BA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix debug.debug() for non-string errors. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patch into all long-term branches in tarantool/luajit and bumped a new version in master, 2.10 and 1.10. On 30.12.21, Sergey Kaplun wrote: > From: Mike Pall > > (cherry picked from f5b0fff5a990004375ad43aa6e6c4a11a8b6eb7e) > > `lua_tostring()` returns NULL for non-string and non-number objects. > Returned value is passed to `fputs()` without check, so that leads to > crash in case of NULL. > > This patch adds the corresponding check. "(error object is not a > string)" is returned in the aforementioned case. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#6548 > --- > > Related issue: https://github.com/tarantool/tarantool/issues/6548 > Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-debug-debug-non-string-err > Tarantool branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-noticket-debug-debug-non-string-err-full-ci > > src/lib_debug.c | 3 ++- > .../debug-non-string-error.test.lua | 26 +++++++++++++++++++ > 2 files changed, 28 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/debug-non-string-error.test.lua > > -- > 2.34.1 > -- Best regards, IM