Re: [Tarantool-patches] [v2][PATCH 4/5] build/ninja: create file lists outside of cmake commands

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!

Thanks for the patch!

LGTM, except a few nits regarding the commit message.

On 02.06.22, Sergey Bronnikov via Tarantool-patches wrote:
> Patch adds a last change required for building LuaJIT with Ninja - using

Typo: s/Patch/The patch/

> glob inside CMake commands (add_custom_command and
> set_source_files_properties) breaks buildng with Ninja.

Typo: s/buildng/building/

> 
> By default CMake generates files suitable for building a project with
> Make. However, it allows to generate files for Ninja too. Ninja [1] may
> build project a bit faster than Make, see comparison in [2].

Typo: s/comparison/the comparison/

> 
> How-to build with Ninja:
> 
> $ cmake -G Ninja -B build -S .
> $ cmake --build build --parallel

Side note: Unfortunately `make test` command (or what should I use for
tests, when build with ninja?) fails with the following error:

| Checking /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua 3 warnings
|
|     /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua:5:121: (W631) line is too long (595 > 120)
|     /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua:7:121: (W631) line is too long (613 > 120)
|     /home/burii/reviews/luajit/ninja/build/src/jit/vmdef.lua:11:121: (W631) line is too long (273 > 120)

But this is the problem of OOS build (default for ninja), not this
patch, IINM.

> 
> 1. https://ninja-build.org/
> 2. https://mesonbuild.com/Simple-comparison.html
> ---
>  src/host/CMakeLists.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/host/CMakeLists.txt b/src/host/CMakeLists.txt
> index e01db87d..1ce3e224 100644
> --- a/src/host/CMakeLists.txt
> +++ b/src/host/CMakeLists.txt

<snipped>

> -- 
> 2.25.1
> 

-- 
Best regards,
Sergey Kaplun