From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] symtab: check the _GNU_SOURCE definition
Date: Thu, 19 May 2022 08:25:32 +0300 [thread overview]
Message-ID: <YoXUzEklaHKWxLAi@root> (raw)
In-Reply-To: <20220518123108.45915-1-m.kokryashkin@tarantool.org>
Hi, Maxim!
Thanks for the patch!
LGTM.
On 18.05.22, Maxim Kokryashkin wrote:
> Now the `_GNU_SOURCE` in `lj_symtab.c` is only defined when it wasn't
> defined yet. That chnage fixes the macro redifinition warning.
Typo: s/chnage/change/
>
> Part of tarantool/tarantool#5813
> ---
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2022-05-19 5:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 12:31 Maxim Kokryashkin via Tarantool-patches
2022-05-18 12:31 ` [Tarantool-patches] [PATCH luajit] sysprof: replace `backtrace` with libunwind Maxim Kokryashkin via Tarantool-patches
2022-05-26 16:33 ` Igor Munkin via Tarantool-patches
2022-05-18 14:31 ` [Tarantool-patches] [PATCH luajit] symtab: check the _GNU_SOURCE definition Igor Munkin via Tarantool-patches
2022-05-19 5:25 ` Sergey Kaplun via Tarantool-patches [this message]
2022-05-26 16:30 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoXUzEklaHKWxLAi@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] symtab: check the _GNU_SOURCE definition' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox