Re: [Tarantool-patches] [PATCH luajit v6 0/2] memprof: C-symbols resolving

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Max,

Thanks for the series! Since release is urgently coming, I've rebase
your series on the current state of tarantool branch by myself. On this
way I've also fixed all issues I've found. Here is kinda full list of
the changes made by me:
* Introduced generations for C symbols.
* Fixed build related issues, since we need to support old CMake
  versions (<target_link_options> is provided only since CMake 3.13).
* Disabled resolver for BSD, since lj_memprof.c fails to build on it.
* Fixed some style issues (C99 for loop declarations, misindent, etc).

All in all, the changeset LGTM, so I've checked the patchset into
tarantool branch in tarantool/luajit and bumped a new version in master.

P.S. I guess we need to throw all our efforts for on intergrational
testing, since I'm sicked of all that PR+ML cocktail leading to the
green CI in tarantool/luajit and the red on in tarantool/tarantool when
bumping LuaJIT submodule.

On 22.03.22, Maxim Kokryashkin wrote:
> Changes in v6:
> - Fixed comments as per review by Sergey
> - Added tests for newly loaded symbols resolution
> 
> ---

<snipped>

> Maxim Kokryashkin (2):
>   memprof: extend symtab with C-symbols
>   memprof: enrich symtab with newly loaded symbols
> 
>  Makefile.original                             |   2 +-
>  src/lj_memprof.c                              | 407 +++++++++++++++++-
>  src/lj_memprof.h                              |  15 +-
>  test/tarantool-tests/CMakeLists.txt           |   1 +
>  .../gh-5813-resolving-of-c-symbols.test.lua   |  60 +++
>  .../CMakeLists.txt                            |   2 +
>  .../testresolving.c                           |  19 +
>  test/tarantool-tests/tools-utils-avl.test.lua |  54 +++
>  tools/CMakeLists.txt                          |   2 +
>  tools/memprof.lua                             |   5 +
>  tools/memprof/parse.lua                       |  19 +
>  tools/utils/avl.lua                           | 114 +++++
>  tools/utils/symtab.lua                        |  27 +-
>  13 files changed, 715 insertions(+), 12 deletions(-)
>  create mode 100644 test/tarantool-tests/gh-5813-resolving-of-c-symbols.test.lua
>  create mode 100644 test/tarantool-tests/gh-5813-resolving-of-c-symbols/CMakeLists.txt
>  create mode 100644 test/tarantool-tests/gh-5813-resolving-of-c-symbols/testresolving.c
>  create mode 100644 test/tarantool-tests/tools-utils-avl.test.lua
>  create mode 100644 tools/utils/avl.lua
> 
> --
> 2.35.1
> 

-- 
Best regards,
IM