From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A5B3D6ECC0; Fri, 22 Apr 2022 16:26:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A5B3D6ECC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1650633985; bh=FwjYOjA5IywfBoIPLzuBbwM2kbwKFjVGsdOHiIH4x4s=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=fLi9t9a7BdJCQJO7arxBlihP35jh2QWuMaOaT1kSrSg5hONYJkZVNdNquD/1HeU4L fabNQPn3XBajkIT+5zoksC2pFocdtGJ1Nv4Sx89C7hssxalpVYBQH+O/9GLU7ISuuO 3DxTkyewBJhrvAU5+9hF6HHviIcCJm/F68XnMGvs= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 43F606ECC0 for ; Fri, 22 Apr 2022 16:26:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 43F606ECC0 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1nhtIl-0000x9-6o; Fri, 22 Apr 2022 16:26:23 +0300 Date: Fri, 22 Apr 2022 16:22:54 +0300 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD977B76FDA87AFA8B9728AAA4496BC78AEF3EF3C2392A15CB5182A05F53808504018ACF22235DDC61930C62221EF399FA23BF8DD42467E2FAC33B5A573544408C6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F6EE1C40B2E8BE15EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371E4BC0E00C009995EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BEBC5CAB6D411FFA62E35636295E9BFCEB8D992BE33ABA436CC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9BFB91CAEB05C77775ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5DDF01BF427C48933E53610725F947BBEBD66839E759EA3A0D59269BC5F550898D99A6476B3ADF6B4886A5961035A09600383DAD389E261318FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342E8FEDBD32DECB6DC54A2DD55DD3DFD83719F3338F85AC2D21DC9C3FE28BDDE4845301A1301E8BB51D7E09C32AA3244C8DB33F1BFCD56F046B2F97C4AC75E2C2C3B3ADDA61883BB583B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojUdgx7RGfjLZ4+IIsye5oDw== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D6933F666B0FC8F0DC993A37F0781CC0B6A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v6 0/2] memprof: C-symbols resolving X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the series! Since release is urgently coming, I've rebase your series on the current state of tarantool branch by myself. On this way I've also fixed all issues I've found. Here is kinda full list of the changes made by me: * Introduced generations for C symbols. * Fixed build related issues, since we need to support old CMake versions ( is provided only since CMake 3.13). * Disabled resolver for BSD, since lj_memprof.c fails to build on it. * Fixed some style issues (C99 for loop declarations, misindent, etc). All in all, the changeset LGTM, so I've checked the patchset into tarantool branch in tarantool/luajit and bumped a new version in master. P.S. I guess we need to throw all our efforts for on intergrational testing, since I'm sicked of all that PR+ML cocktail leading to the green CI in tarantool/luajit and the red on in tarantool/tarantool when bumping LuaJIT submodule. On 22.03.22, Maxim Kokryashkin wrote: > Changes in v6: > - Fixed comments as per review by Sergey > - Added tests for newly loaded symbols resolution > > --- > Maxim Kokryashkin (2): > memprof: extend symtab with C-symbols > memprof: enrich symtab with newly loaded symbols > > Makefile.original | 2 +- > src/lj_memprof.c | 407 +++++++++++++++++- > src/lj_memprof.h | 15 +- > test/tarantool-tests/CMakeLists.txt | 1 + > .../gh-5813-resolving-of-c-symbols.test.lua | 60 +++ > .../CMakeLists.txt | 2 + > .../testresolving.c | 19 + > test/tarantool-tests/tools-utils-avl.test.lua | 54 +++ > tools/CMakeLists.txt | 2 + > tools/memprof.lua | 5 + > tools/memprof/parse.lua | 19 + > tools/utils/avl.lua | 114 +++++ > tools/utils/symtab.lua | 27 +- > 13 files changed, 715 insertions(+), 12 deletions(-) > create mode 100644 test/tarantool-tests/gh-5813-resolving-of-c-symbols.test.lua > create mode 100644 test/tarantool-tests/gh-5813-resolving-of-c-symbols/CMakeLists.txt > create mode 100644 test/tarantool-tests/gh-5813-resolving-of-c-symbols/testresolving.c > create mode 100644 test/tarantool-tests/tools-utils-avl.test.lua > create mode 100644 tools/utils/avl.lua > > -- > 2.35.1 > -- Best regards, IM