Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v6 0/2] memprof: C-symbols resolving
Date: Mon, 4 Apr 2022 11:45:52 +0300	[thread overview]
Message-ID: <YkqwQMYYK2wDZrS6@root> (raw)
In-Reply-To: <cover.1647972832.git.m.kokryashkin@tarantool.org>

Hi, Maxim!

Thanks for the fixes.

On 22.03.22, Maxim Kokryashkin wrote:
> Changes in v6:
> - Fixed comments as per review by Sergey
> - Added tests for newly loaded symbols resolution
> 
> ---
> >> +#include <stdlib.h>
> >> +#include <string.h>
> >
> > <string.h> and <stdlib.h> are included inside lj_def.h, so this include is excess.
> Relying on includes in other header files is a terrible practice. Ignoring.

Yes, but it is common for LuaJIT. :)

> 

<snipped>

> 
> --
> 2.35.1
> 

-- 
Best regards,
Sergey Kaplun

  parent reply	other threads:[~2022-04-04  8:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 18:31 Maxim Kokryashkin via Tarantool-patches
2022-03-22 18:31 ` [Tarantool-patches] [PATCH luajit v6 1/2] memprof: extend symtab with C-symbols Maxim Kokryashkin via Tarantool-patches
2022-04-04  8:43   ` Sergey Kaplun via Tarantool-patches
2022-04-04 11:34     ` Sergey Kaplun via Tarantool-patches
2022-03-22 18:31 ` [Tarantool-patches] [PATCH luajit v6 2/2] memprof: enrich symtab with newly loaded symbols Maxim Kokryashkin via Tarantool-patches
2022-04-04  8:44   ` Sergey Kaplun via Tarantool-patches
2022-04-04  8:45 ` Sergey Kaplun via Tarantool-patches [this message]
2022-04-22 13:22 ` [Tarantool-patches] [PATCH luajit v6 0/2] memprof: C-symbols resolving Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkqwQMYYK2wDZrS6@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v6 0/2] memprof: C-symbols resolving' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox