From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: sergos <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Add missing LJ_MAX_JSLOTS check.
Date: Wed, 6 Apr 2022 10:21:13 +0300 [thread overview]
Message-ID: <Yk0/acQ1E4R+rKxd@root> (raw)
In-Reply-To: <AD208E28-D3E8-4100-BF31-FD75A369C99B@tarantool.org>
Hi!
Thanks for the review!
On 30.03.22, sergos wrote:
> Hi! Thanks for updates!
>
> LGTM with a very small nit fix you’ve missed in the test comment.
Fixed. Branch is force pushed.
===================================================================
diff --git a/test/tarantool-tests/fix-slot-check-for-mm-record.test.lua b/test/tarantool-tests/fix-slot-check-for-mm-record.test.lua
index e361830d..94a27d18 100644
--- a/test/tarantool-tests/fix-slot-check-for-mm-record.test.lua
+++ b/test/tarantool-tests/fix-slot-check-for-mm-record.test.lua
@@ -20,7 +20,7 @@ _G.a0 = a0
-- Fixarg function with call to metamethod.
local function a1()
- -- This constant is not setted as an upvalue to simplify stack
+ -- This constant is not set as an upvalue to simplify stack
-- slots counting. Just remember that it is 42.
return a0 + 42
end
===================================================================
>
> Sergos
>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2022-04-06 7:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 11:46 Sergey Kaplun via Tarantool-patches
2022-03-25 15:51 ` sergos via Tarantool-patches
2022-03-28 10:02 ` Sergey Kaplun via Tarantool-patches
2022-03-30 10:02 ` sergos via Tarantool-patches
2022-04-06 7:21 ` Sergey Kaplun via Tarantool-patches [this message]
2022-06-27 19:58 ` Igor Munkin via Tarantool-patches
2022-06-28 6:39 ` Sergey Kaplun via Tarantool-patches
2022-06-30 12:08 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk0/acQ1E4R+rKxd@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergos@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] Add missing LJ_MAX_JSLOTS check.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox