From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 62C1C6ECC0; Wed, 6 Apr 2022 10:23:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 62C1C6ECC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1649229803; bh=qErwHIkyxUU/xX02uiaEGPiYO2x2k2J6SpSNghVyIG0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xP+GdvmWQKupTUhDyOA7nGIsa6gstwK0PEy9DUUKaCtilkfqUluUruZ/U8iY4DKQi 9y4/JWYCVDq95QdSSRo/Btr9kUI2CzRwd8oQPRVl2oeuUBeVRkNjLqHi0AU4DFn72s BY+M0EqkHQy9+UJBDz5el2UCo8Vo2YJATJW9bEqI= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E67F16ECC0 for ; Wed, 6 Apr 2022 10:23:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E67F16ECC0 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1nc00e-0000DE-OP; Wed, 06 Apr 2022 10:23:21 +0300 Date: Wed, 6 Apr 2022 10:21:13 +0300 To: sergos Message-ID: References: <20211022114653.4225-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD90FA8EB11E8F64C5668880C5449ED4B458E6EB3CF4D4DAF50182A05F538085040C26C930E84671D16AC6D7B5699527267C7EA2D821FB50B3B40866EE1795BC39E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922FDBD9EBA3C5B4B287FD4696A6DC2FA8DF7F3B2552694A4E2F5AFA99E116B42401471946AA11AF23F8577A6DFFEA7C7DA205A7C69714208F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB55337566DC7574C48649A355EEBF77D712568FB4EC3A657C4FFF09B3A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658359CC434672EE6371117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B8F435DEDE9E76EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A52CE5B279E68868CA729216B62B29A195F85738374A2721A2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7593FFA1BBD54C7608410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B7CBFF60649FF2665F7DBBB9A8010C478F2B4C98648FD23C5EC243432AC8B37C8B1162EA443F432A1D7E09C32AA3244C33CA989F0BB13EDD6BD0EBC440BED0A951E887DA02A9F7BFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj1v5/e2DytTqPWuT2wE/GIA== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D6B18EE7B29B3A264C47A8EA36538E0DF70FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Add missing LJ_MAX_JSLOTS check. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! On 30.03.22, sergos wrote: > Hi! Thanks for updates! > > LGTM with a very small nit fix you’ve missed in the test comment. Fixed. Branch is force pushed. =================================================================== diff --git a/test/tarantool-tests/fix-slot-check-for-mm-record.test.lua b/test/tarantool-tests/fix-slot-check-for-mm-record.test.lua index e361830d..94a27d18 100644 --- a/test/tarantool-tests/fix-slot-check-for-mm-record.test.lua +++ b/test/tarantool-tests/fix-slot-check-for-mm-record.test.lua @@ -20,7 +20,7 @@ _G.a0 = a0 -- Fixarg function with call to metamethod. local function a1() - -- This constant is not setted as an upvalue to simplify stack + -- This constant is not set as an upvalue to simplify stack -- slots counting. Just remember that it is 42. return a0 + 42 end =================================================================== > > Sergos > -- Best regards, Sergey Kaplun