Re: [Tarantool-patches] [PATCH luajit v2 1/3] memprof: add symbol epochs

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi!

Thanks for the patch!
Please, sorry for such long response.
LGTM, except a few nits regarding the commit message.

Also, maybe we should add some tests to the patch?
Case for traces looks easy, doesn't it?

On 02.12.21, Mikhail Shishatskiy wrote:
> There may be situations, when new prototype or trace has the same
> address than the previously dumped one. In this case, the new symtab
> entry will shadow the preceeding, and if we demangle symbols when all

Typo: s/preceeding/preceding one/

> the events are parsed, we can get irrelevant information.
> 
> For this reason, the symtab now stores not a single entry, but array of

Typo: s/array/the array/

> entries for each location. The structure <loc> was extended by the field
> <epoch> representing the generation of symtab entry associated with this
> particular location entry. Also, the <utils/symtab.lua> API has extended
> by function symtab.new_loc(symbols, addr, line, traceno) so that it can
> assign an epoch for a new location.
> 
> Part of tarantool/tarantool#5815
> ---

-- 
Best regards,
Sergey Kaplun