From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v31 3/3] test: add gh-6036-qsync-order test
Date: Thu, 3 Mar 2022 14:02:32 +0300 [thread overview]
Message-ID: <YiCgSE6UTIk5Dpcp@grain> (raw)
In-Reply-To: <b9a83dd7-d74b-3771-ffa0-ad1a41225d73@tarantool.org>
On Thu, Mar 03, 2022 at 01:08:59PM +0300, Serge Petrenko wrote:
>
> 02.03.2022 23:27, Cyrill Gorcunov пишет:
> > To test that promotion requests are handled only when appropriate
> > write to WAL completes, because we update memory data before the
> > write finishes.
> >
> > Part-of #6036
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>
>
> Thanks for working on this!
>
> Please consider the following cosmetic changes:
>
> 1. There's build_and_add_server as an alias for build_server + add_server
>
> 2. Use luatest.assert instead of plain assert everywhere
>
> 3. Use exec instead of eval everywhere
Thanks a huge, Serge! Will update and force push.
prev parent reply other threads:[~2022-03-03 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 20:27 [Tarantool-patches] [PATCH v31 0/3] qsync: implement packet filtering (part 1) Cyrill Gorcunov via Tarantool-patches
2022-03-02 20:27 ` [Tarantool-patches] [PATCH v31 1/3] latch: add latch_is_locked helper Cyrill Gorcunov via Tarantool-patches
2022-03-02 20:27 ` [Tarantool-patches] [PATCH v31 2/3] qsync: order access to the limbo terms Cyrill Gorcunov via Tarantool-patches
2022-03-02 20:27 ` [Tarantool-patches] [PATCH v31 3/3] test: add gh-6036-qsync-order test Cyrill Gorcunov via Tarantool-patches
2022-03-03 10:08 ` Serge Petrenko via Tarantool-patches
2022-03-03 11:02 ` Cyrill Gorcunov via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiCgSE6UTIk5Dpcp@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v31 3/3] test: add gh-6036-qsync-order test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox