Re: [Tarantool-patches] [PATCH luajit v2] test: adapt disabled tests from PUC-Rio

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Max,

Here are the remaining nits.

On 21.01.22, Максим Корякшин wrote:
> 
> Hi, Sergey!
> Thanks for the review!
>  
> New commit message with your comments in mind:
> =========================================================
> test: adapt disabled tests from PUC-Rio
>  
> Version and status are printed in stdout instead of stderr
> since LuaJIT-2.0.0-beta11 (as it is not an error message). This behavior
> is the same as in Lua 5.2, so necessary changes in tests can be
> adapted from PUC-Rio Lua 5.2 test suite.
>  
> However, those tests are disabled for Tarantool since its interactive
> shell doesn't support '=' at the beginning of statements.
> Here is an example:
> |$ luajit
> |> = (6*2-6) -- ===
> |6
> |
> |$ tarantool
> |tarantool> = (6*2-6) -- ===
> |---
> |- error: ' (6*2-6) -- ===:1: unexpected symbol near ''='''
> |...

It's better to use a space between | and the body (like email client
does) for readability. So this part should look like this:
| $ luajit
| > = (6*2-6) -- ===
| 6
| 
| $ tarantool
| tarantool> = (6*2-6) -- ===
| ---
| - error: ' (6*2-6) -- ===:1: unexpected symbol near ''='''
| ...


>  
> Part of tarantool/tarantool#5870
> Resolves tarantool/tarantool#5687

Please, move "Resolves" tag prior to "Part of" one.

> =========================================================

<snipped>

> > 

-- 
Best regards,
IM