From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] gdb: add mmudata value to lj-gc output
Date: Fri, 11 Feb 2022 22:12:08 +0300 [thread overview]
Message-ID: <Yga1CFIn67SljozR@tarantool.org> (raw)
In-Reply-To: <YgOXeDMSOjJrXzrG@root>
Sergey,
Thanks for your review!
On 09.02.22, Sergey Kaplun wrote:
> Hi, Igor!
>
> Thanks for the patch!
>
> LGTM, except a single nit regarding commit message below.
Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
>
> On 01.02.22, Igor Munkin wrote:
> > As a result of this patch <g->gc.mmudata> value representing the amount
> > of GC object to be finalized is added to <lj-gc> output. All auxiliary
>
> Typo: s/to <lj-gc> output/to the <lj-gc> output/
Well, I almost sure there is no need for the definite article here.
Ignoring.
>
> > routines are also adjusted a bit since these GC objects are grouped in a
> > ring-list.
> >
<snipped>
>
> --
> Best regards,
> Sergey Kaplun
--
Best regards,
IM
next prev parent reply other threads:[~2022-02-11 19:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 21:33 [Tarantool-patches] [PATCH 0/2] Minor enhancements in luajit-gdb.py Igor Munkin via Tarantool-patches
2022-01-31 21:33 ` [Tarantool-patches] [PATCH 1/2] gdb: unwind Lua stack top part Igor Munkin via Tarantool-patches
2022-02-09 10:14 ` Sergey Kaplun via Tarantool-patches
2022-02-09 18:02 ` Maxim Kokryashkin via Tarantool-patches
2022-02-11 19:11 ` Igor Munkin via Tarantool-patches
2022-02-11 19:11 ` Igor Munkin via Tarantool-patches
2022-01-31 21:33 ` [Tarantool-patches] [PATCH 2/2] gdb: add mmudata value to lj-gc output Igor Munkin via Tarantool-patches
2022-02-09 10:29 ` Sergey Kaplun via Tarantool-patches
2022-02-09 18:11 ` Maxim Kokryashkin via Tarantool-patches
2022-02-11 19:12 ` Igor Munkin via Tarantool-patches
2022-02-11 19:12 ` Igor Munkin via Tarantool-patches [this message]
2022-02-01 10:17 ` [Tarantool-patches] [PATCH 0/2] Minor enhancements in luajit-gdb.py Igor Munkin via Tarantool-patches
2022-02-11 20:42 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yga1CFIn67SljozR@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] gdb: add mmudata value to lj-gc output' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox