Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] gdb: add mmudata value to lj-gc output
Date: Wed, 9 Feb 2022 13:29:12 +0300	[thread overview]
Message-ID: <YgOXeDMSOjJrXzrG@root> (raw)
In-Reply-To: <793426cc622083a73c9f8f2ff34779b7b82cb7f8.1643645066.git.imun@tarantool.org>

Hi, Igor!

Thanks for the patch!

LGTM, except a single nit regarding commit message below.

On 01.02.22, Igor Munkin wrote:
> As a result of this patch <g->gc.mmudata> value representing the amount
> of GC object to be finalized is added to <lj-gc> output. All auxiliary

Typo: s/to <lj-gc> output/to the <lj-gc> output/

> routines are also adjusted a bit since these GC objects are grouped in a
> ring-list.
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>  src/luajit-gdb.py | 35 +++++++++++++++++++++++++++--------
>  1 file changed, 27 insertions(+), 8 deletions(-)
> 
> diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
> index 758ba10c..baf66f66 100644
> --- a/src/luajit-gdb.py
> +++ b/src/luajit-gdb.py

<snipped>

> -- 
> 2.34.0
> 

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2022-02-09 10:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 21:33 [Tarantool-patches] [PATCH 0/2] Minor enhancements in luajit-gdb.py Igor Munkin via Tarantool-patches
2022-01-31 21:33 ` [Tarantool-patches] [PATCH 1/2] gdb: unwind Lua stack top part Igor Munkin via Tarantool-patches
2022-02-09 10:14   ` Sergey Kaplun via Tarantool-patches
2022-02-09 18:02     ` Maxim Kokryashkin via Tarantool-patches
2022-02-11 19:11       ` Igor Munkin via Tarantool-patches
2022-02-11 19:11     ` Igor Munkin via Tarantool-patches
2022-01-31 21:33 ` [Tarantool-patches] [PATCH 2/2] gdb: add mmudata value to lj-gc output Igor Munkin via Tarantool-patches
2022-02-09 10:29   ` Sergey Kaplun via Tarantool-patches [this message]
2022-02-09 18:11     ` Maxim Kokryashkin via Tarantool-patches
2022-02-11 19:12       ` Igor Munkin via Tarantool-patches
2022-02-11 19:12     ` Igor Munkin via Tarantool-patches
2022-02-01 10:17 ` [Tarantool-patches] [PATCH 0/2] Minor enhancements in luajit-gdb.py Igor Munkin via Tarantool-patches
2022-02-11 20:42 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgOXeDMSOjJrXzrG@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 2/2] gdb: add mmudata value to lj-gc output' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox