Re: [Tarantool-patches] [PATCH 2/2] gdb: add mmudata value to lj-gc output

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]


Hi, Igor!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
 
  
>Среда, 9 февраля 2022, 13:31 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:
> 
>Hi, Igor!
>
>Thanks for the patch!
>
>LGTM, except a single nit regarding commit message below.
>
>On 01.02.22, Igor Munkin wrote:
>> As a result of this patch <g->gc.mmudata> value representing the amount
>> of GC object to be finalized is added to <lj-gc> output. All auxiliary
>
>Typo: s/to <lj-gc> output/to the <lj-gc> output/
>
>> routines are also adjusted a bit since these GC objects are grouped in a
>> ring-list.
>>
>> Signed-off-by: Igor Munkin < imun@tarantool.org >
>> ---
>> src/luajit-gdb.py | 35 +++++++++++++++++++++++++++--------
>> 1 file changed, 27 insertions(+), 8 deletions(-)
>>
>> diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
>> index 758ba10c..baf66f66 100644
>> --- a/src/luajit-gdb.py
>> +++ b/src/luajit-gdb.py
>
><snipped>
>
>> --
>> 2.34.0
>>
>
>--
>Best regards,
>Sergey Kaplun
 

[-- Attachment #2: Type: text/html, Size: 1631 bytes --]