From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] test: adapt tests checking traceback in tail call Date: Thu, 17 Feb 2022 19:36:58 +0300 [thread overview] Message-ID: <Yg55qr3QXxTj9d30@tarantool.org> (raw) In-Reply-To: <20210924172519.121517-1-m.kokryashkin@tarantool.org> Max, I've checked the patch into all long-term branches in tarantool/luajit and bumped a new version in 1.10, 2.8 and master. On 24.09.21, Maxim Kokryashkin wrote: > LuaJIT does not provide information about tail calls > unlike, Lua 5.1 does, so a traceback in LuaJIT may be different. > > Consider this chunck of code: > ``` > local function checktraceback (co, p) > local tb = debug.traceback(co) > local i = 0 > for l in string.gmatch(tb, "[^\n]+\n?") do > assert(i == 0 or string.find(l, p[i])) > i = i+1 > end > assert(p[i] == nil) > end > > local function f (n) > if n > 0 then return f(n-1) > else coroutine.yield() end > end > > local co = coroutine.create(f) > coroutine.resume(co, 3) > checktraceback(co, {"yield", "db.lua", "tail", "tail", "tail"}) > ``` > > For LuaJIT traceback looks like the following: > ``` > stack traceback: > [C]: in function 'yield' > db.lua:436: in function <db.lua:434> > ``` > > And for Lua 5.1 it looks like the following: > ``` > stack traceback: > [C]: in function 'yield' > db.lua:436: in function <db.lua:434> > (tail call): ? > (tail call): ? > (tail call): ? > ``` > > Closes tarantool/tarantool#5703 > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > Issue: https://github.com/tarantool/tarantool/issues/5703 > GitHub branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-5703-adapt-traceback-tail-call-PUC-Rio > > test/PUC-Rio-Lua-5.1-tests/db.lua | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > <snipped> > -- > 2.33.0 > -- Best regards, IM
prev parent reply other threads:[~2022-02-17 16:40 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-24 17:25 Maxim Kokryashkin via Tarantool-patches 2021-09-24 18:28 ` Максим Корякшин via Tarantool-patches 2021-10-11 15:11 ` Sergey Kaplun via Tarantool-patches 2021-11-09 16:59 ` Максим Корякшин via Tarantool-patches 2022-02-11 19:12 ` Igor Munkin via Tarantool-patches 2022-02-14 22:21 ` Maxim Kokryashkin via Tarantool-patches 2022-02-17 16:36 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yg55qr3QXxTj9d30@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit] test: adapt tests checking traceback in tail call' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox