Re: [Tarantool-patches] [PATCH luajit] test: adapt tests checking traceback in tail call

["Максим Корякшин via Tarantool-patches" <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2707 bytes --]


Hi!
I have fixed a typo in the commit, so here is the diff:
=============================================================
diff --git a/test/PUC-Rio-Lua-5.1-tests/db.lua b/test/PUC-Rio-Lua-5.1-tests/db.lua
index f254cde6..fce85b19 100644
--- a/test/PUC-Rio-Lua-5.1-tests/db.lua
+++ b/test/PUC-Rio-Lua-5.1-tests/db.lua
@@ -475,7 +475,7 @@ end
 local co = coroutine.create(f)
 coroutine.resume(co, 3)
--- Test is adapted to the behaviour of LuaJIT.
+-- Test is adapted to the behavior of LuaJIT.
 checktraceback(co, {"yield", "db.lua"})
=============================================================
 
Best regards,
Maxim Kokryashkin
   
>LuaJIT does not provide information about tail calls
>unlike, Lua 5.1 does, so a traceback in LuaJIT may be different.
>
>Consider this chunck of code:
>```
>local function checktraceback (co, p)
>  local tb = debug.traceback(co)
>  local i = 0
>  for l in string.gmatch(tb, "[^\n]+\n?") do
>    assert(i == 0 or string.find(l, p[i]))
>    i = i+1
>  end
>  assert(p[i] == nil)
>end
>
>local function f (n)
>  if n > 0 then return f(n-1)
>  else coroutine.yield() end
>end
>
>local co = coroutine.create(f)
>coroutine.resume(co, 3)
>checktraceback(co, {"yield", "db.lua", "tail", "tail", "tail"})
>```
>
>For LuaJIT traceback looks like the following:
>```
>stack traceback:
>        [C]: in function 'yield'
>        db.lua:436: in function <db.lua:434>
>```
>
>And for Lua 5.1 it looks like the following:
>```
>stack traceback:
>        [C]: in function 'yield'
>        db.lua:436: in function <db.lua:434>
>        (tail call): ?
>        (tail call): ?
>        (tail call): ?
>```
>
>Closes tarantool/tarantool#5703
>Part of tarantool/tarantool#5845
>Part of tarantool/tarantool#4473
>---
>Issue:  https://github.com/tarantool/tarantool/issues/5703
>GitHub branch:  https://github.com/tarantool/luajit/tree/fckxorg/gh-5703-adapt-traceback-tail-call-PUC-Rio
>
> test/PUC-Rio-Lua-5.1-tests/db.lua | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/test/PUC-Rio-Lua-5.1-tests/db.lua b/test/PUC-Rio-Lua-5.1-tests/db.lua
>index 56f59ea8..f254cde6 100644
>--- a/test/PUC-Rio-Lua-5.1-tests/db.lua
>+++ b/test/PUC-Rio-Lua-5.1-tests/db.lua
>@@ -475,9 +475,8 @@ end
> 
> local co = coroutine.create(f)
> coroutine.resume(co, 3)
>--- FIXME: Behavior is different for LuaJIT.
>--- See the comment to `h()` above. Test is disabled for LuaJIT.
>--- checktraceback(co, {"yield", "db.lua", "tail", "tail", "tail"})
>+-- Test is adapted to the behaviour of LuaJIT.
>+checktraceback(co, {"yield", "db.lua"})
> 
> 
> co = coroutine.create(function (x)
>--
>2.33.0
 

[-- Attachment #2: Type: text/html, Size: 3812 bytes --]