From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] test: adapt test checking global environment Date: Thu, 17 Feb 2022 19:34:12 +0300 [thread overview] Message-ID: <Yg55BBN/l5kQz6Jr@tarantool.org> (raw) In-Reply-To: <20211006130444.3031234-1-m.kokryashkin@tarantool.org> Max, I've checked the patch into all long-term branches in tarantool/luajit and bumped a new version in 1.10, 2.8 and master. On 06.10.21, Maxim Kokryashkin wrote: > LuaJIT doesn't take into account tail calls for > call-level counting, so `getfenv()` behaviour is different > in tail calls. getfenv()` default level is 1 which is invalid for > the test case when is called from tail call (`lj_debug_frame()` > returns NULL). > > This commits adds local varibles, so there is no tail call any more. > > Part of tarantool/tarantool#5870 > --- > Issue: https://github.com/tarantool/tarantool/issues/5713 > GitHub branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-5713-adapt-test-global-environment-PUC-Rio > CI: https://github.com/tarantool/tarantool/tree/fckxorg/gh-5713-adapt-test-global-environment-PUC-Rio > > test/PUC-Rio-Lua-5.1-tests/closure.lua | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > <snipped> > -- > 2.33.0 > -- Best regards, IM
next prev parent reply other threads:[~2022-02-17 16:37 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-06 13:04 Maxim Kokryashkin via Tarantool-patches 2021-12-16 14:34 ` Sergey Kaplun via Tarantool-patches 2022-01-17 23:42 ` Максим Корякшин via Tarantool-patches 2022-01-26 22:33 ` Igor Munkin via Tarantool-patches 2022-02-07 9:32 ` Максим Корякшин via Tarantool-patches 2022-01-17 23:43 ` Максим Корякшин via Tarantool-patches 2022-02-17 16:34 ` Igor Munkin via Tarantool-patches [this message] -- strict thread matches above, loose matches on Subject: below -- 2021-09-24 18:20 Maxim Kokryashkin via Tarantool-patches 2021-10-05 17:37 ` Sergey Kaplun via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yg55BBN/l5kQz6Jr@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit] test: adapt test checking global environment' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox