Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Mikhail Shishatskiy <m.shishatskiy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2] memprof: report JIT-side allocations as internal
Date: Wed, 2 Feb 2022 20:26:35 +0300	[thread overview]
Message-ID: <Yfq+ywzYhVq6H5c3@tarantool.org> (raw)
In-Reply-To: <20210821044353.kbbgcgiapat2q4ve@surf.localdomain>


Thanks for the patch! LGTM, except the single nit.

On 21.08.21, Mikhail Shishatskiy wrote:
> Hi, Sergey!
> Thanks for the review!


> +
> + -- Test for marking JIT-related allocations as internal.
> + -- See also https://github.com/tarantool/tarantool/issues/5679.
> + subtest:ok(alloc[0] == nil)

As a result of the changes made in scope of #5814, this line need to be
adjusted the following way:
| subtest:ok(alloc.line[0] == nil)

> +
> + -- Run already generated traces.


> Best regards,
> Mikhail Shishatskiy

Best regards,

  parent reply	other threads:[~2022-02-02 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  9:34 Mikhail Shishatskiy via Tarantool-patches
2021-08-14 11:24 ` Sergey Kaplun via Tarantool-patches
2021-08-21  4:43   ` Mikhail Shishatskiy via Tarantool-patches
2021-11-24 13:01     ` Mikhail Shishatskiy via Tarantool-patches
2022-02-02 17:26     ` Igor Munkin via Tarantool-patches [this message]
2022-02-02 17:29 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yfq+ywzYhVq6H5c3@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.shishatskiy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v2] memprof: report JIT-side allocations as internal' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox