From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9C2216F867; Wed, 2 Feb 2022 20:29:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9C2216F867 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1643822976; bh=Cp5mF79t/kqvqt1eEzkA5JEgufBIrCjg328msC6uSWg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rO75zYykKKPq87uefmWavW3aUKZSJwCDV5vhJorUnR326o7Qd23ktfpuK96on25S/ r9vVR9PEViu+hakPGLgmCxyTEcL89zf1ydDbyowporVP06MAxQFoE0dJNJlC37Ad10 VPZKcZKbTqNUrza2ZQRyD3fJfgoQgOyNWf/f8it8= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E54856F867 for ; Wed, 2 Feb 2022 20:29:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E54856F867 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1nFJRl-0002F9-Sn; Wed, 02 Feb 2022 20:29:34 +0300 Date: Wed, 2 Feb 2022 20:26:35 +0300 To: Mikhail Shishatskiy Message-ID: References: <20210821044353.kbbgcgiapat2q4ve@surf.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210821044353.kbbgcgiapat2q4ve@surf.localdomain> X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD99F281FB7F96F126D1412A99C1709EDA7DD4D3583615D673E00894C459B0CD1B97826267D6AE05EFFC15BF3F431EC8BE7B2EA80D39A14EDF370FEF0169C8C4278 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71EAE3A63419E5AEDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063779089FB2CE4EA2908638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8120776243F84A39B56FBF7D6FCCE56AA117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B60A9A04DE7321024275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A553B60B016FEF98A8EFA7ADF68102074CEECF3BE2E7CFA974D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75BF6B963DD989C0FC410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34524B2D44961BF9C6E9262B9DA1A01B0BB760BA498208CE2C4925937E796C4C968CF6894080750AA31D7E09C32AA3244C2A95BDAD849BF1945E292AEBD67918F54DBEAD0ED6C55A80927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojKfO1XyIHtDKoxNz/zYwiXA== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D69FBB105D3878EE787EE157E6C3EF0B2AA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] memprof: report JIT-side allocations as internal X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Misha, Thanks for the patch! LGTM, except the single nit. On 21.08.21, Mikhail Shishatskiy wrote: > Hi, Sergey! > Thanks for the review! > > + > + -- Test for marking JIT-related allocations as internal. > + -- See also https://github.com/tarantool/tarantool/issues/5679. > + subtest:ok(alloc[0] == nil) As a result of the changes made in scope of #5814, this line need to be adjusted the following way: | subtest:ok(alloc.line[0] == nil) > + > + -- Run already generated traces. > > Best regards, > Mikhail Shishatskiy -- Best regards, IM