From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Fix string.char() recording with no arguments.
Date: Fri, 28 Jan 2022 18:12:21 +0300 [thread overview]
Message-ID: <YfQH1SCaYyyE/qjE@root> (raw)
In-Reply-To: <YfPtdbl3LuP+Annm@tarantool.org>
Igor,
On 28.01.22, Igor Munkin wrote:
> Sergey,
>
> On 28.01.22, Sergey Kaplun wrote:
> > Igor,
> > Thanks for the review!
> >
>
> <snipped>
>
> > >
> > > I see no assertion running the test in Debug, unfortunately. Could you
> > > please provide the way to hit it?
> >
> > I build as usual:
> > | $ cmake . -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_APICHECK=ON -DLUA_USE_ASSERT=ON && make -j
>
> PEBKAC, I totally forgot to enable LUA_USE_APICHECK and LUA_USE_ASSERT.
> I guess it's time to enable both by default for Debug. Thoughts?
I'm OK with it. Not against at least. :)
>
> <snipped>
>
> >
> > --
> > Best regards,
> > Sergey Kaplun
>
> --
> Best regards,
> IM
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2022-01-28 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 15:48 Sergey Kaplun via Tarantool-patches
2021-08-31 11:39 ` Sergey Ostanevich via Tarantool-patches
2021-09-01 7:10 ` Sergey Kaplun via Tarantool-patches
2022-01-10 11:48 ` sergos via Tarantool-patches
2022-01-27 21:46 ` Igor Munkin via Tarantool-patches
2022-01-27 22:02 ` Igor Munkin via Tarantool-patches
2022-01-28 8:26 ` Sergey Kaplun via Tarantool-patches
2022-01-28 12:49 ` Sergey Kaplun via Tarantool-patches
2022-01-28 13:19 ` Igor Munkin via Tarantool-patches
2022-01-28 15:12 ` Sergey Kaplun via Tarantool-patches [this message]
2022-02-11 19:09 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfQH1SCaYyyE/qjE@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] Fix string.char() recording with no arguments.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox