Re: [Tarantool-patches] [PATCH luajit v4 0/4] memprof: group allocations on traces by traceno

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Misha,

Thanks for the series! I totally forgot: I've checked the patch into
tarantool branch in tarantool/luajit and bumped a new version in master.

On 29.09.21, Mikhail Shishatskiy wrote:
> New patch series v4 with fixes as per review by Igor Munkin:
> 
> Changes in v4:
>   * refactored the modules in order not to violate MVC: now
>     process module uses the symtab.id(loc) as a key (but not the
>     fully demangled name)
>   * reorganized patches: now the first important patch has the
>     location dumping and simple parsing without the trace start
>     info; the second patch adds the information about the trace's
>     start and extends the symtab.
> 
> @ChangeLog
> ======================================================================
> ##feature/luajit
> 
> * Now memory profiler records allocations from traces. The memory
>   profiler parser can display new type of allocation sources in
>   the following format:
>   ```
>   | TRACE [<trace-no>] <trace-addr> started at @<sym-chunk>:<sym-line>
>   ```
> ======================================================================
> 
> Mikhail Shishatskiy (4):
>   test: separate memprof Lua API tests into subtests
>   memprof: refactor location parsing
>   memprof: group allocations on traces by traceno
>   memprof: add info about trace start to symtab
> 
>  src/Makefile.dep.original                     |   3 +-
>  src/lj_memprof.c                              |  79 +++++-
>  src/lj_memprof.h                              |  22 +-
>  .../misclib-memprof-lapi.test.lua             | 261 ++++++++++++------
>  tools/memprof.lua                             |   4 +-
>  tools/memprof/humanize.lua                    |  30 +-
>  tools/memprof/parse.lua                       |  39 +--
>  tools/memprof/process.lua                     |   9 +-
>  tools/utils/symtab.lua                        |  49 +++-
>  9 files changed, 364 insertions(+), 132 deletions(-)
> 

<snipped>

> 
> -- 
> 2.33.0
> 

-- 
Best regards,
IM