From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Fix string.char() recording with no arguments. Date: Fri, 28 Jan 2022 01:02:26 +0300 [thread overview] Message-ID: <YfMWcmf1lnfdetPN@tarantool.org> (raw) In-Reply-To: <YfMSu8jAfEdupEfC@tarantool.org> Sergey, On 28.01.22, Igor Munkin wrote: > Sergey, > > Thanks for the patch! Please consider my comments below. > > On 20.08.21, Sergey Kaplun wrote: > > From: Mike Pall <mike> > > > > (cherry picked from commit dfa692b746c9de067857d5fc992a41730be3d99a) > > > > `string.char()` call without arguments yields an empty string. When JIT > > machinery records the aforementioned call it doesn't handle this case. > > Each recording fast function expects 1 result by default. Hence, when > > Typo: double space prior to "Hence". Damn, I was looking at the old patch, but you've already fixed it in the newer version. Sorry, feel free to ignore this nit. > <snipped> > > -- > Best regards, > IM -- Best regards, IM
next prev parent reply other threads:[~2022-01-27 22:03 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-20 15:48 Sergey Kaplun via Tarantool-patches 2021-08-31 11:39 ` Sergey Ostanevich via Tarantool-patches 2021-09-01 7:10 ` Sergey Kaplun via Tarantool-patches 2022-01-10 11:48 ` sergos via Tarantool-patches 2022-01-27 21:46 ` Igor Munkin via Tarantool-patches 2022-01-27 22:02 ` Igor Munkin via Tarantool-patches [this message] 2022-01-28 8:26 ` Sergey Kaplun via Tarantool-patches 2022-01-28 12:49 ` Sergey Kaplun via Tarantool-patches 2022-01-28 13:19 ` Igor Munkin via Tarantool-patches 2022-01-28 15:12 ` Sergey Kaplun via Tarantool-patches 2022-02-11 19:09 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YfMWcmf1lnfdetPN@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Fix string.char() recording with no arguments.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox