From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B22D56F873; Fri, 28 Jan 2022 01:03:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B22D56F873 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1643321033; bh=nFFyvgKRNWU8eS2pylRAb/MYKjlTEtXWEhtFZlX7Oug=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F77D9+/MMRYlH+aWRwF0yy2lYVFdO+Nny0FFCv81FGw8GvtbREK6LohnZWhySThRS q19y87Wbymh2LOa27ysJNi9xntxIfHtmduefjXjQW/xBvyFcfUOK/AXhu1ZFwFgSYX d6QkfHUa/KWROMiBIMelJmJ3B3uhQh5de3ojmP1o= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 751616F873 for ; Fri, 28 Jan 2022 01:03:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 751616F873 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1nDCrv-0000uD-ID; Fri, 28 Jan 2022 01:03:51 +0300 Date: Fri, 28 Jan 2022 01:02:26 +0300 To: Sergey Kaplun Message-ID: References: <20210820154846.5515-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9AA78FDF62ECAE61F54255EDFAF4B1D201624D376D056B765182A05F538085040C74508FB602EDC1FC1313D45F5A8A3FA2FC64AB8118111CFA91A16F9359C966A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7956F10FFCC7409BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E16D8B060A9A23898638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B8BC4E36EC6AEEECFD3AC3DD4745C81E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B68A0907C648FB30DE089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5FA3BB001E2B885B5941560D09772FDCA281F5D52F98D3E05D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75438CC92D4039F4E2410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348F343DA43F62289F3F82D896CEE74C508A2E816A7D4DE2FB5B11CC909C393CDFE20B1DE4FAF8F7561D7E09C32AA3244CA36C0D03E0593385712D93014999056D725D5B54B2FE4575927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqLK0kLh8sGcxWmbb9UbAUQ== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D6F4B363EEE82268185C7F0C363E59B072A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix string.char() recording with no arguments. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 28.01.22, Igor Munkin wrote: > Sergey, > > Thanks for the patch! Please consider my comments below. > > On 20.08.21, Sergey Kaplun wrote: > > From: Mike Pall > > > > (cherry picked from commit dfa692b746c9de067857d5fc992a41730be3d99a) > > > > `string.char()` call without arguments yields an empty string. When JIT > > machinery records the aforementioned call it doesn't handle this case. > > Each recording fast function expects 1 result by default. Hence, when > > Typo: double space prior to "Hence". Damn, I was looking at the old patch, but you've already fixed it in the newer version. Sorry, feel free to ignore this nit. > > > -- > Best regards, > IM -- Best regards, IM