From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>,
Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Fix tonumber("-0") in dual-number mode.
Date: Thu, 27 Jan 2022 12:50:12 +0300 [thread overview]
Message-ID: <YfJq1J6idC4qXHs7@root> (raw)
In-Reply-To: <6ab9d085d486a481362259063598825a14f6876b.1643199076.git.skaplun@tarantool.org>
Hi, again!
On 26.01.22, Sergey Kaplun wrote:
> From: Mike Pall <mike>
>
> Reported by Sergey Kaplun.
>
Added the corresponding line to the commit:
| (cherry picked from commit 103c29e634d822e0affd7d3ae16a7d8a80c038d3)
Branch is force pushed.
> For DUALNUM build `tonumber("-0x0")` or `tonumber("-0")` returns 0
> instead -0 due to the STRSCAN_OPT_TOINT option of `lj_strscan_scan()`
> and cast value to integer with losing information about its sign.
>
> This patch adds special checks for these corner cases during strscan.
>
> Sergey Kaplun:
> * added the description and the test for the problem
>
> Part of tarantool/tarantool#6548
> ---
<snipped>
>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2022-01-27 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 12:19 [Tarantool-patches] [PATCH luajit 0/2] Fix tonumber("-0") inconsistencies Sergey Kaplun via Tarantool-patches
2022-01-26 12:19 ` [Tarantool-patches] [PATCH luajit 1/2] Fix tonumber("-0") Sergey Kaplun via Tarantool-patches
2022-06-27 13:47 ` Igor Munkin via Tarantool-patches
2022-06-27 20:29 ` sergos via Tarantool-patches
2022-01-26 12:19 ` [Tarantool-patches] [PATCH luajit 2/2] Fix tonumber("-0") in dual-number mode Sergey Kaplun via Tarantool-patches
2022-01-27 9:50 ` Sergey Kaplun via Tarantool-patches [this message]
2022-06-27 13:48 ` Igor Munkin via Tarantool-patches
2022-06-27 15:51 ` sergos via Tarantool-patches
2022-06-30 12:09 ` [Tarantool-patches] [PATCH luajit 0/2] Fix tonumber("-0") inconsistencies Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfJq1J6idC4qXHs7@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=sergos@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 2/2] Fix tonumber("-0") in dual-number mode.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox