From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v19 2/3] qsync: order access to the limbo terms
Date: Wed, 6 Oct 2021 00:52:07 +0300 [thread overview]
Message-ID: <YVzJB9D87R6agdy+@grain> (raw)
In-Reply-To: <19aec308-075f-c9f0-44a7-959c9d4a8193@tarantool.org>
On Tue, Oct 05, 2021 at 04:25:21PM +0300, Serge Petrenko wrote:
>
> Here's what can happen. You're the old leader, and you've received a
> promote from someone else already, it's being written now.
> Now some replica sends you an ack. You enter txn_limbo_ack
> (it doesn't check the latch). txn_limbo_ack() may result in writing a
> CONFIRM.
>
> The PROMOTE is already in progress, so you'll end up writing CONFIRM for
> a wrong leader id (your own) after PROMOTE is written.
This sounds like we need more general lock for limbo operations. And
as we have been discussing already for box change params as well. I'm
starting to doubt that promote latch is a good name. Anyway I'll prepare
a draft version and send it out.
next prev parent reply other threads:[~2021-10-05 21:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 9:44 [Tarantool-patches] [PATCH v19 0/3] qsync: implement packet filtering (part 1) Cyrill Gorcunov via Tarantool-patches
2021-09-30 9:44 ` [Tarantool-patches] [PATCH v19 1/3] latch: add latch_is_locked helper Cyrill Gorcunov via Tarantool-patches
2021-09-30 9:44 ` [Tarantool-patches] [PATCH v19 2/3] qsync: order access to the limbo terms Cyrill Gorcunov via Tarantool-patches
2021-10-01 12:14 ` Serge Petrenko via Tarantool-patches
2021-10-01 12:31 ` Cyrill Gorcunov via Tarantool-patches
2021-10-01 12:37 ` Serge Petrenko via Tarantool-patches
2021-10-04 21:53 ` Cyrill Gorcunov via Tarantool-patches
2021-10-05 13:25 ` Serge Petrenko via Tarantool-patches
2021-10-05 21:52 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-09-30 9:44 ` [Tarantool-patches] [PATCH v19 3/3] test: add gh-6036-qsync-order test Cyrill Gorcunov via Tarantool-patches
2021-10-01 12:30 ` Serge Petrenko via Tarantool-patches
2021-10-04 21:16 ` Cyrill Gorcunov via Tarantool-patches
2021-10-05 13:55 ` Serge Petrenko via Tarantool-patches
2021-10-05 22:26 ` Cyrill Gorcunov via Tarantool-patches
2021-10-05 22:32 ` Cyrill Gorcunov via Tarantool-patches
2021-10-06 7:06 ` Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVzJB9D87R6agdy+@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v19 2/3] qsync: order access to the limbo terms' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox