Re: [Tarantool-patches] [PATCH v17 4/5] qsync: export more details on promote tracking

[Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

On Mon, Sep 27, 2021 at 10:00:28AM +0300, Serge Petrenko wrote:
> 
> 
> 22.09.2021 16:05, Cyrill Gorcunov пишет:
> > The patch introduces `promote` leaf to `box.info.synchro` table.
> > 
> >   | tarantool> box.info.synchro
> >   | ---
> >   | - queue:
> >   |     len: 0
> >   |     owner: 1
> >   |   quorum: 1
> >   |   promote:
> >   |     term_max: 4
> >   |     term_map: {1: 4}
> >   | ...
> > 
> > An idea is to be able to track changes of seen requests. Since it is
> > internal implementation details I prefer to not document it. Actually
> > better to mark is as non-API somehow.
> 
> I think this info might be useful, so maybe document it as well?
> 
> I'd call it `journal`, probably.
> box.info.synchro.journal.term - what you call term_max
> box.info.synchro.journal.term_map

You know, I don't mind :) We need to choose "info" leaves and branches
names very carefully though, because it becomes API. So I guess we
could consider journal branch where we would gather not only synchro
related information but extend output for debug/stat sake in future?

box.info
  journal:
    synchro: (replication related info)
      term: 4
      term_map: {1: 4}
    queue: (flush queue related info)
      len: 12
    stat:
      wrote: 400 bytes

I don't have strong opinion which form is better, I'm fine with any,
just sharing an idea.