Re: [Tarantool-patches] [PATCH v16 0/3] qsync: implement packet filtering (part 1)

[Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

On Thu, Sep 16, 2021 at 12:51:37AM +0200, Vladislav Shpilevoy wrote:
> On 15.09.2021 16:50, Cyrill Gorcunov via Tarantool-patches wrote:
> > Packet filtering takes more and more time to implement and I send
> > similar patches again multiple times. Still the complete split brain
> > detection is not yet done, so I thought it might be worth to split the
> > work into several series. This part addresses a race with terms manipulation
> > and I think can be considered as its own.
> > 
> > I would really appreciate comments here mostly due to function naming,
> > comments and etc. My primary aim was to make sure that this series doesn't
> > break anything existing but I think if we would have a test case for this
> > ordering issue it would be brilliant, though I didn't come with some simple
> > one here yet.
> 
> Committing a part of the series won't speed up the other patches, unfortunately.
> If you think something can be done separately, it is a good idea. But still
> such changes must be independent and have their own tests then.
> 
> Just pushing some first commits won't help with the next ones.

Could you please at least comment "function naming, comments in code and etc",
so the lack of test would be the only issue.