Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladimir Davydov via Tarantool-patches
	<tarantool-patches@dev.tarantool.org>
Cc: v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] net.box: allow to store user-defined fields in future object
Date: Tue, 10 Aug 2021 20:15:27 +0300	[thread overview]
Message-ID: <YRK0L7oBohEObD0v@grain> (raw)
In-Reply-To: <ba159cef7c33bb8eef3044a18dfdef9f0ac330e1.1628614117.git.vdavydov@tarantool.org>

On Tue, Aug 10, 2021 at 07:53:54PM +0300, Vladimir Davydov via Tarantool-patches wrote:
> +
> +static int
> +luaT_netbox_request_newindex(struct lua_State *L)
> +{
> +	struct netbox_request *request = luaT_check_netbox_request(L, 1);
> +	struct mh_strnptr_t *h = request->index;
> +	size_t field_name_len;
> +	const char *field_name = lua_tolstring(L, 2, &field_name_len);
> +	if (field_name == NULL)
> +		return luaL_error(L, "invalid index");
> +	int field_value_ref = luaL_ref(L, LUA_REGISTRYINDEX);
> +	if (field_value_ref == LUA_REFNIL) {
> +		/* The field is set to nil. Delete it from the index. */
> +		if (h == NULL)
> +			return 0;
> +		mh_int_t k = mh_strnptr_find_inp(h, field_name,
> +						 field_name_len);

We're guaranteed that field_name present in a hash and never
ever return nil, right? Sorry I don't understand this code just
found this moment suspicious.

  reply	other threads:[~2021-08-10 17:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 16:53 Vladimir Davydov via Tarantool-patches
2021-08-10 17:15 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-08-11  7:49   ` Vladimir Davydov via Tarantool-patches
2021-08-12 17:07     ` [Tarantool-patches] [PATCH v2] " Vladimir Davydov via Tarantool-patches
2021-08-12 18:02 ` [Tarantool-patches] [PATCH] " Vladislav Shpilevoy via Tarantool-patches
2021-08-12 18:13   ` Vladislav Shpilevoy via Tarantool-patches
2021-08-13 10:01   ` Vladimir Davydov via Tarantool-patches
2021-08-12 18:13 ` Igor Munkin via Tarantool-patches
2021-08-13  9:57   ` Vladimir Davydov via Tarantool-patches
2021-08-13  9:59     ` [Tarantool-patches] [PATCH v3] " Vladimir Davydov via Tarantool-patches
2021-08-14 11:17       ` Igor Munkin via Tarantool-patches
2021-08-16  8:27         ` Vladimir Davydov via Tarantool-patches
2021-08-16  8:56           ` Igor Munkin via Tarantool-patches
2021-08-16 11:32             ` Vitaliia Ioffe via Tarantool-patches
2021-08-16 11:35               ` Vladimir Davydov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRK0L7oBohEObD0v@grain \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] net.box: allow to store user-defined fields in future object' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox