From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v8 3/6] limbo: gather promote tracking into a separate structure
Date: Thu, 29 Jul 2021 09:40:55 +0300 [thread overview]
Message-ID: <YQJNdxp/kaS6Z7ZP@grain> (raw)
In-Reply-To: <5f0235c4-628c-f29b-097a-48f7203320cd@tarantool.org>
On Thu, Jul 29, 2021 at 12:07:44AM +0200, Vladislav Shpilevoy wrote:
> >
> > The key moment here is the locking we use for terms tracking,
> > note the locking is not covering the whole limbo thus better
> > to keep the lock itself inside the structure it protects I think.
>
> Yes, the struct it protects is the limbo. Part of. I see no sense
> to extract the members you protect into a new struct just because
> only they are protected.
It doesn't protect limbo itself, the entries are added to the queue
without taking a lock (in contrast with cbus), so I completely don't
agree with your arguments. Still I'm fine to move these members back
to the limbo structure as you prefer. Will do.
next prev parent reply other threads:[~2021-07-29 6:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 15:34 [Tarantool-patches] [PATCH v8 0/6] limbo: implement packets filtering Cyrill Gorcunov via Tarantool-patches
2021-07-26 15:34 ` [Tarantool-patches] [PATCH v8 1/6] latch: add latch_is_locked helper Cyrill Gorcunov via Tarantool-patches
2021-07-26 15:34 ` [Tarantool-patches] [PATCH v8 2/6] say: introduce panic_on helper Cyrill Gorcunov via Tarantool-patches
2021-07-26 15:34 ` [Tarantool-patches] [PATCH v8 3/6] limbo: gather promote tracking into a separate structure Cyrill Gorcunov via Tarantool-patches
2021-07-28 21:34 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 21:57 ` Cyrill Gorcunov via Tarantool-patches
2021-07-28 22:07 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-29 6:40 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-07-26 15:34 ` [Tarantool-patches] [PATCH v8 4/6] limbo: order access to the limbo terms terms Cyrill Gorcunov via Tarantool-patches
2021-07-26 15:34 ` [Tarantool-patches] [PATCH v8 5/6] limbo: filter incoming synchro requests Cyrill Gorcunov via Tarantool-patches
2021-07-26 15:34 ` [Tarantool-patches] [PATCH v8 6/6] test: replication -- add gh-6036-rollback-confirm Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQJNdxp/kaS6Z7ZP@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v8 3/6] limbo: gather promote tracking into a separate structure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox