From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C94596EC55; Thu, 29 Jul 2021 09:40:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C94596EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627540859; bh=xza+VLZFC7aCF0O2u9GYudS96mOgSQ2QIeexAyqBdsY=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=MtJWlC3fdeyyAvaMswNvIUziwnXsWlVmr51/rno2Q7PNyO0wZ5kFr5XwYjxwyEQHz ywefcKeWBA2cTcYP4wfkkp+9yonMFhL3l1ImVX3apk4xALSoAe5Je35EFy1kbPagN5 HgcLuZ9MAZlBUwwzyQ8wNA0eo2C/jWPDUmxnXMTE= Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F36BD6EC55 for ; Thu, 29 Jul 2021 09:40:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F36BD6EC55 Received: by mail-lf1-f50.google.com with SMTP id bp1so8990004lfb.3 for ; Wed, 28 Jul 2021 23:40:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FhB/KuLyj8hHFbDzvStBsr3vZPPOJMh38jL4id2fR5s=; b=Hh8lJU1sMzrf+L/uRetNkUbbw9FftwRYSH74FeIJqvkmya1z/DwPUKL5eCGKL6GdQb 8dvuySoGD2WysdYkDmUPfkRJLoS09IHd+sirKXv0gv3HYQm4yOe1tUfEY1Wxh8NvWNTf OBy5wmQaKJMA0RPc3GxDTv13mXZAg/aENFizB8OEtOX5NtOHexkBK79j3fzNMG7q6Gt7 8yKA8jptImjTaxtln5dUxAgM99+PCmdcOdxAfUc55BnzyCYhIYHLVTmO5wf4Dl/sVWGF CivED9ll5M4AMoOEY/eGdVDGl52qX5KwECoC8HjQMLAr2rLpd4DfW9wuZw2E9G8YpgdA SzsQ== X-Gm-Message-State: AOAM532KZFKVE0Nwaxw+3DLZE5XjGwOqvHw55dl5EcD8WuSfDZXGyqqU BeHEzHlsvO1qMG2HHh183BcWelSB8cwoOg== X-Google-Smtp-Source: ABdhPJyGe2ZYD1iwdP4YtsLclwMpqfuGTxTesJFnc0uGY4zvQiJ6csZfWEkiEMnXKfLiPxY5GM2vMQ== X-Received: by 2002:ac2:4d28:: with SMTP id h8mr2576870lfk.303.1627540857876; Wed, 28 Jul 2021 23:40:57 -0700 (PDT) Received: from grain.localdomain ([5.18.255.97]) by smtp.gmail.com with ESMTPSA id u16sm57387lfo.135.2021.07.28.23.40.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 23:40:56 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id AFBDA5A001E; Thu, 29 Jul 2021 09:40:55 +0300 (MSK) Date: Thu, 29 Jul 2021 09:40:55 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210726153452.113897-1-gorcunov@gmail.com> <20210726153452.113897-4-gorcunov@gmail.com> <3a64d0ce-b2aa-d331-942e-b60484638dd9@tarantool.org> <5f0235c4-628c-f29b-097a-48f7203320cd@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f0235c4-628c-f29b-097a-48f7203320cd@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v8 3/6] limbo: gather promote tracking into a separate structure X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Jul 29, 2021 at 12:07:44AM +0200, Vladislav Shpilevoy wrote: > > > > The key moment here is the locking we use for terms tracking, > > note the locking is not covering the whole limbo thus better > > to keep the lock itself inside the structure it protects I think. > > Yes, the struct it protects is the limbo. Part of. I see no sense > to extract the members you protect into a new struct just because > only they are protected. It doesn't protect limbo itself, the entries are added to the queue without taking a lock (in contrast with cbus), so I completely don't agree with your arguments. Still I'm fine to move these members back to the limbo structure as you prefer. Will do.