Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Egor Elchinov via Tarantool-patches
	<tarantool-patches@dev.tarantool.org>
Cc: Egor Elchinov <elchinov.es@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v3 0/4] fiber: introduce creation backtrace
Date: Fri, 16 Jul 2021 09:12:47 +0300
Message-ID: <YPEjX3UvPDqq1BBr@grain> (raw)
In-Reply-To: <cover.1626260838.git.elchinov.es@gmail.com>

On Wed, Jul 14, 2021 at 02:12:48PM +0300, Egor Elchinov via Tarantool-patches wrote:
> From: Egor Elchinov <elchinov.es@gmail.com>
> 
> This patchset adds the subtable `backtrace_parent()`
> to `fiber.info()` holding backtraces of fiber
> creation and introduces `fiber.parent_bt_enable()`
> and `fiber.parent_bt_disable()` procedures managing
> the runtime ability to collect parent backtraces for
> newly created fibers.
> 
> Changes in v2:
>  - first 3 patches merged together
>  - unnecessary changes in `ENABLE_BACKTRACE` usages reverted
> 
> Changes in v3:
>  - strncpy() and snprintf() usages fixed
>  - error check for dladdr() under macos added

The series looks good to me, well done, Egor! Ack.

  parent reply	other threads:[~2021-07-16  6:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 11:12 Egor Elchinov via Tarantool-patches
2021-07-14 11:12 ` [Tarantool-patches] [PATCH v3 1/4] fiber: add PoC for fiber " Egor Elchinov via Tarantool-patches
2021-07-14 11:12 ` [Tarantool-patches] [PATCH v3 2/4] fiber: add option and PoC for Lua parent backtrace Egor Elchinov via Tarantool-patches
2021-07-14 11:12 ` [Tarantool-patches] [PATCH v3 3/4] fiber: refactor lua backtrace routines Egor Elchinov via Tarantool-patches
2021-07-14 11:12 ` [Tarantool-patches] [PATCH v3 4/4] fiber: refactor C backtrace and add changelog Egor Elchinov via Tarantool-patches
2021-07-16  6:12 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-07-27 11:53 ` [Tarantool-patches] [PATCH v3 0/4] fiber: introduce creation backtrace Vladimir Davydov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPEjX3UvPDqq1BBr@grain \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=elchinov.es@gmail.com \
    --cc=gorcunov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git