From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3803B6EC55; Fri, 16 Jul 2021 09:12:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3803B6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1626415971; bh=t+9fCmjC3mAU3I9+NcifCv2FiGIpOgfpqFjaN8pB5eI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=bW5/jHGr4/3GRNhVc6BB0+kxSWWW+WeetryBtYMSEtvivt+LKKlDSLTF5G1k0ilmI k566Ji0fEbvQKz3S9SPPKqOMU+t0dbt7S5BCMZFPxHufaWSGf1+7MFNv46fS2uj0Hp GJKFYB/xMAsEU/4woyhv0R4TTkR18ucwikI0WCy4= Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 17B966EC55 for ; Fri, 16 Jul 2021 09:12:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 17B966EC55 Received: by mail-lf1-f42.google.com with SMTP id i5so14194007lfe.2 for ; Thu, 15 Jul 2021 23:12:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+b8w9kRyod9FnW4zxqEpNplqdA1pNhqEi4FfNFx80ko=; b=VfJIQum8TMcyZm/jFH32rByzsMv4+nPmAc2vD0KDVbdZYBC+bZWPSTeJC3br6Utzxw qwj62uoFSL8Kpgm4/z7yP38rzW/vwrW1GwY1Jsgahs32Lvyw1drFZ72N+ZRx22fT0W5Z t4OxmibKDD1yZ0OIEN1CTtfbz+8P8u6DXA/BbIPGLIHilYBB4hLBzJqr6wtr5gXBUhn+ zeGTM0GiafdMlOcTS5b7SaSLYx7x2EtKA3rRknp0V6MXvldhF4ilcN+fPOoSEvrmmt0Q dVd3Vdy2BDSJDBZzYIMKsbCyWhoTD+OT7IY7hucBnLpcsYDL26zXbJcWIKDAUQgV04n7 IWgQ== X-Gm-Message-State: AOAM530jJiBlyQrt3FT+uc7fWo4mHc0K36yZoUen33jkXrcq+8PSLlZe 3oxw+tVpJMgKRf/6HRYiWU2JhmTJnHbaNA== X-Google-Smtp-Source: ABdhPJxwTDmJWA6bDlqc8nRULkXbmQUtizZPPC/e1Q8N9O2nRUDcrJNqGmkJ+4lvcF+5BbCiY6KZJQ== X-Received: by 2002:a05:6512:603:: with SMTP id b3mr6172075lfe.469.1626415969073; Thu, 15 Jul 2021 23:12:49 -0700 (PDT) Received: from grain.localdomain ([5.18.255.97]) by smtp.gmail.com with ESMTPSA id z20sm874315ljk.123.2021.07.15.23.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 23:12:47 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 258945A001E; Fri, 16 Jul 2021 09:12:47 +0300 (MSK) Date: Fri, 16 Jul 2021 09:12:47 +0300 To: Egor Elchinov via Tarantool-patches Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v3 0/4] fiber: introduce creation backtrace X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Egor Elchinov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Jul 14, 2021 at 02:12:48PM +0300, Egor Elchinov via Tarantool-patches wrote: > From: Egor Elchinov > > This patchset adds the subtable `backtrace_parent()` > to `fiber.info()` holding backtraces of fiber > creation and introduces `fiber.parent_bt_enable()` > and `fiber.parent_bt_disable()` procedures managing > the runtime ability to collect parent backtraces for > newly created fibers. > > Changes in v2: > - first 3 patches merged together > - unnecessary changes in `ENABLE_BACKTRACE` usages reverted > > Changes in v3: > - strncpy() and snprintf() usages fixed > - error check for dladdr() under macos added The series looks good to me, well done, Egor! Ack.