From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [RFC v5 4/5] limbo: order access to the promote terms
Date: Thu, 15 Jul 2021 15:20:10 +0300 [thread overview]
Message-ID: <YPAn+rYlp5qWh/Db@grain> (raw)
In-Reply-To: <5e43c72a-b837-2437-4e8c-e7ef739f0476@tarantool.org>
On Thu, Jul 15, 2021 at 02:48:48PM +0300, Serge Petrenko wrote:
>
> I think all panic_on(!cond) invocations may be replaced with assert(cond)
>
> Even if we use some functions incorrectly, this may be catched by an
> assertion.
You know, initially I thought of using assert as well but then
realized that our test's coverage is far from being perfect
so that if we manage to miss locking, the results are really
awfull - data become inconsistent as far as I understand. So
I would prefer to have panic_on here. But if you still prefer
assert then sure, I'll drop panic_on.
next prev parent reply other threads:[~2021-07-15 12:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 21:23 [Tarantool-patches] [RFC v5 0/5] limbo: implement packets filtering Cyrill Gorcunov via Tarantool-patches
2021-07-14 21:23 ` [Tarantool-patches] [RFC v5 1/5] latch: add latch_is_locked helper Cyrill Gorcunov via Tarantool-patches
2021-07-15 11:15 ` Serge Petrenko via Tarantool-patches
2021-07-14 21:23 ` [Tarantool-patches] [RFC v5 2/5] say: introduce panic_on helper Cyrill Gorcunov via Tarantool-patches
2021-07-14 21:23 ` [Tarantool-patches] [RFC v5 3/5] limbo: gather promote tracking into a separate structure Cyrill Gorcunov via Tarantool-patches
2021-07-15 11:28 ` Serge Petrenko via Tarantool-patches
2021-07-15 11:46 ` Cyrill Gorcunov via Tarantool-patches
2021-07-15 12:00 ` Serge Petrenko via Tarantool-patches
2021-07-15 12:20 ` Cyrill Gorcunov via Tarantool-patches
2021-07-14 21:23 ` [Tarantool-patches] [RFC v5 4/5] limbo: order access to the promote terms Cyrill Gorcunov via Tarantool-patches
2021-07-15 11:48 ` Serge Petrenko via Tarantool-patches
2021-07-15 12:20 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-07-14 21:23 ` [Tarantool-patches] [RFC v5 5/5] limbo: filter incoming requests Cyrill Gorcunov via Tarantool-patches
2021-07-15 11:59 ` Serge Petrenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPAn+rYlp5qWh/Db@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [RFC v5 4/5] limbo: order access to the promote terms' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox