Re: [Tarantool-patches] [PATCH v2 03/10] test: use CI friendly variables in lua-Harness

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!

Thanks for the patch!
LGTM except a few nits regarding to the commit message.

===================================================================
    test: use CI friendly variables in lua-Harness

    In scope of the commit 45ed138dcb9228d8ac5b8d82331ddd20a0bfada1

Typo: s/In scope/In the scope/

    ('test: set USERNAME env var for lua-Harness suite') the environment
    of the testing process is tweaked via CMake, since both LOGNAME and
    USERNAME environment variables might be missing.

    Actually, POSIX standard states that every user must have HOME
    environment variable set. It allows to use this in the corresponding

Typo? s/this/this variable/

    assertion instead of LOGNAME and USERNAME without additional
    environment setup.

    As a result this patch[1] from lua-Harness suite supersedes the
    mentioned commit, and CMake hack can be dropped.

Typo: s/CMake hack/the CMake hack/


    [1]: https://framagit.org/fperrad/lua-Harness/-/commit/6c2aa87

    Part of tarantool/tarantool#5970
    Part of tarantool/tarantool#4473
===================================================================
On 26.07.21, Igor Munkin wrote:
> Max,
> 
> Thanks for the fixes! LGTM.
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun