From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Egor Elchinov <eelchinov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 5/7] fiber: add dynamic option for parent backtrace
Date: Fri, 9 Jul 2021 13:10:39 +0300 [thread overview]
Message-ID: <YOggn+A49mJ5NPEX@grain> (raw)
In-Reply-To: <39ad0898-6d05-227c-adda-dcb50e6ec573@tarantool.org>
On Fri, Jul 09, 2021 at 12:50:40PM +0300, Egor Elchinov wrote:
> > > -#ifdef ENABLE_BACKTRACE
> > > +#if ENABLE_BACKTRACE
> >
> > Please don't squash unrelated changes into the patch. If you prefer
> > to shange #ifdef to #if better make it as a separate commit (though
> > I don't understand yet what is wrong with existing code)
> Changes rebased into refactoring commit.
>
> I believe this is more conventional way to check the ENABLE_BACKTRACE option
> because it is defined as
> #cmakedefine ENABLE_BACKTRACE 1
> but not
> #cmakedefine ENABLE_BACKTRACE
For this particular case we don't check the _value_ of defined variable,
we rather interested if it is defined at all. In general for conditional compilation
we use #ifdef you know, and all our current code uses #ifdef ENABLE_BACKTRACE
so I personally don't see much point in renaming statement. Still,
up to you, but if you prefer #if form could you please make it as a separate
patch.
Cyrill
next prev parent reply other threads:[~2021-07-09 10:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 20:24 [Tarantool-patches] [PATCH 0/7] fiber: introduce creation backtrace Egor Elchinov via Tarantool-patches
2021-07-01 20:24 ` [Tarantool-patches] [PATCH 1/7] fiber: add PoC for fiber " Egor Elchinov via Tarantool-patches
2021-07-01 20:44 ` Egor Elchinov via Tarantool-patches
2021-07-02 7:00 ` Egor Elchinov via Tarantool-patches
2021-07-02 7:11 ` [Tarantool-patches] [PATCH v2 " Egor Elchinov via Tarantool-patches
2021-07-01 20:24 ` [Tarantool-patches] [PATCH 2/7] fiber: fix DARWIN build Egor Elchinov via Tarantool-patches
2021-07-01 20:24 ` [Tarantool-patches] [PATCH 3/7] fiber: apply fix patch Egor Elchinov via Tarantool-patches
2021-07-05 9:42 ` Cyrill Gorcunov via Tarantool-patches
2021-07-09 9:32 ` Egor Elchinov via Tarantool-patches
2021-07-01 20:24 ` [Tarantool-patches] [PATCH 4/7] fiber: add PoC for Lua parent backtrace Egor Elchinov via Tarantool-patches
2021-07-01 20:24 ` [Tarantool-patches] [PATCH 5/7] fiber: add dynamic option for " Egor Elchinov via Tarantool-patches
2021-07-05 9:49 ` Cyrill Gorcunov via Tarantool-patches
2021-07-09 9:50 ` Egor Elchinov via Tarantool-patches
2021-07-09 10:10 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-07-01 20:24 ` [Tarantool-patches] [PATCH 6/7] fiber: refactor lua backtrace routine Egor Elchinov via Tarantool-patches
2021-07-01 20:24 ` [Tarantool-patches] [PATCH 7/7] fiber: refactor C backtrace and add changelog Egor Elchinov via Tarantool-patches
-- strict thread matches above, loose matches on Subject: below --
2021-07-01 15:54 [Tarantool-patches] [PATCH 0/7] fiber: introduce creation backtrace Egor Elchinov via Tarantool-patches
2021-07-01 15:54 ` [Tarantool-patches] [PATCH 5/7] fiber: add dynamic option for parent backtrace Egor Elchinov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOggn+A49mJ5NPEX@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=eelchinov@tarantool.org \
--cc=gorcunov@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH 5/7] fiber: add dynamic option for parent backtrace' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox