From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] raft: more precise verification of incoming request state
Date: Thu, 8 Jul 2021 01:05:00 +0300 [thread overview]
Message-ID: <YOYlDDZCTJbs20gq@grain> (raw)
In-Reply-To: <YOYjxUdVKXBe0mW6@grain>
On Thu, Jul 08, 2021 at 12:59:33AM +0300, Cyrill Gorcunov wrote:
> > 2. You deleted the state decode. I assume not a single replication
> > test passes now, correct?
>
> Nope :) I write it back a bit later once verification is complete.
> I ran the test locally before sending the patch.
Vlad, I think I know what happened: there was a typo which I fixed
and commited locally but didn't force pushed out. Just realized it.
I updated repo. But since we gonna switch to uintX instead of enum
I think it doesn't worth to resend the patch.
next prev parent reply other threads:[~2021-07-07 22:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 10:07 Cyrill Gorcunov via Tarantool-patches
2021-06-25 21:49 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-25 21:49 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-26 13:34 ` Cyrill Gorcunov via Tarantool-patches
2021-06-27 14:12 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-27 19:42 ` Cyrill Gorcunov via Tarantool-patches
2021-07-02 13:43 ` Cyrill Gorcunov via Tarantool-patches
2021-07-07 21:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-07 21:59 ` Cyrill Gorcunov via Tarantool-patches
2021-07-07 22:05 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-07-08 9:28 ` [Tarantool-patches] [PATCH v3] raft: change request state to uint64_t Cyrill Gorcunov via Tarantool-patches
2021-07-08 21:17 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOYlDDZCTJbs20gq@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] raft: more precise verification of incoming request state' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox