From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/7] replication: always send raft state to subscribers
Date: Thu, 10 Jun 2021 19:47:18 +0300 [thread overview]
Message-ID: <YMJCFlZGQHyz4Z3+@grain> (raw)
In-Reply-To: <ee5c37f76190c26139b5873c195f29b89ffdccd1.1623331925.git.sergepetrenko@tarantool.org>
On Thu, Jun 10, 2021 at 04:32:51PM +0300, Serge Petrenko wrote:
> - if (raft_is_enabled(box_raft())) {
> + if (replica_version_id >= version_id(2, 6, 0) && !anon) {
> /*
> * Send out the current raft state of the instance. Don't do
> - * that if Raft is disabled. It can be that a part of the
> - * cluster still contains old versions, which can't handle Raft
> - * messages. So when it is disabled, its network footprint
> - * should be 0.
> + * that if the remote instance is old. It can be that a part of
> + * the cluster still contains old versions, which can't handle
> + * Raft messages. Raft's network footprint should be 0 as seen
> + * by such instances.
> */
Serge, why can't we send raft state for anon replicas as well? As far
as I understand anon replicas do receive raft updates from WAL notifications,
right? So this is somehow inconsistent that WAL's based raft updates are
reaching anon replicas while initial state from subscribe state is not,
or I miss something?
next prev parent reply other threads:[~2021-06-10 16:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 13:32 [Tarantool-patches] [PATCH 0/7] forbid implicit limbo ownership transition Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 1/7] replication: always send raft state to subscribers Serge Petrenko via Tarantool-patches
2021-06-10 16:47 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-06-11 8:43 ` Serge Petrenko via Tarantool-patches
2021-06-11 8:44 ` Cyrill Gorcunov via Tarantool-patches
2021-06-15 20:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 2/7] replication: forbid implicit limbo owner transition Serge Petrenko via Tarantool-patches
2021-06-15 20:55 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:49 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 10:13 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 3/7] txn_limbo: fix promote term filtering Serge Petrenko via Tarantool-patches
2021-06-15 20:57 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:49 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 8:55 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 4/7] txn_limbo: persist the latest effective promote in snapshot Serge Petrenko via Tarantool-patches
2021-06-15 20:59 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 5/7] replication: send latest effective promote in initial join Serge Petrenko via Tarantool-patches
2021-06-15 21:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 10:12 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 6/7] box: introduce `box.ctl.demote` Serge Petrenko via Tarantool-patches
2021-06-18 22:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 14:56 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 7/7] box: make promote/demote always bump the term Serge Petrenko via Tarantool-patches
2021-06-15 21:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 15:02 ` Serge Petrenko via Tarantool-patches
2021-06-15 20:53 ` [Tarantool-patches] [PATCH 0/7] forbid implicit limbo ownership transition Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMJCFlZGQHyz4Z3+@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/7] replication: always send raft state to subscribers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox