From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v9 0/1] applier: filter incoming synchro packets via transaction initiator
Date: Sun, 20 Jun 2021 20:17:42 +0300 [thread overview]
Message-ID: <YM94NpONtBTorIJH@grain> (raw)
In-Reply-To: <14359465-de4b-8475-f717-a3f19a053737@tarantool.org>
On Sun, Jun 20, 2021 at 04:50:10PM +0200, Vladislav Shpilevoy wrote:
>
> It looks better, but why did you ignore my first comment?
> I remind it here:
>
> Maybe better rename it to gh-6035-election-filter. Because otherwise
> this test is not included when I run `python test-run.py election`. And I
> do that quite often when make a patch which affects election only.
I didn't ignore it. Renamed it locally after I've sent you the fixes,
simply because if was more convenient for me to make the rename
as a last step. Everything is pushed into the branch. Thanks.
src/box/applier.cc | 27 ++++++++++---------
src/lib/raft/raft.h | 7 -----
test/replication/gh-5445-leader-inconsistency.result | 15 +++++++++++
test/replication/gh-5445-leader-inconsistency.test.lua | 5 ++++
test/replication/gh-6035-election-filter.result | 139 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
test/replication/gh-6035-election-filter.test.lua | 64 ++++++++++++++++++++++++++++++++++++++++++++
test/replication/gh-6035-master.lua | 1 +
test/replication/gh-6035-node.lua | 34 +++++++++++++++++++++++
test/replication/gh-6035-replica1.lua | 1 +
test/replication/gh-6035-replica2.lua | 1 +
test/replication/suite.cfg | 1 +
(I just looked into our repo and force pushed it again just to be sure)
next prev parent reply other threads:[~2021-06-20 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 13:56 Cyrill Gorcunov via Tarantool-patches
2021-06-15 13:56 ` [Tarantool-patches] [PATCH v9 1/1] " Cyrill Gorcunov via Tarantool-patches
2021-06-15 14:26 ` Serge Petrenko via Tarantool-patches
2021-06-15 17:02 ` Cyrill Gorcunov via Tarantool-patches
2021-06-15 18:08 ` Cyrill Gorcunov via Tarantool-patches
2021-06-16 8:31 ` Serge Petrenko via Tarantool-patches
2021-06-16 8:43 ` Cyrill Gorcunov via Tarantool-patches
2021-06-16 8:16 ` Serge Petrenko via Tarantool-patches
2021-06-18 21:49 ` [Tarantool-patches] [PATCH v9 0/1] " Vladislav Shpilevoy via Tarantool-patches
2021-06-18 22:16 ` Cyrill Gorcunov via Tarantool-patches
2021-06-18 22:58 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-19 11:01 ` Cyrill Gorcunov via Tarantool-patches
2021-06-20 14:50 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-20 17:17 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-06-21 21:06 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YM94NpONtBTorIJH@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v9 0/1] applier: filter incoming synchro packets via transaction initiator' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox