From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/4] ARM, ARM64, PPC: Fix TSETR fallback.
Date: Fri, 4 Jun 2021 18:39:42 +0300 [thread overview]
Message-ID: <YLpJPstNugmwEjEG@root> (raw)
In-Reply-To: <A972A6CA-118F-49E7-A78D-6D5DB9C2B347@tarantool.org>
On 04.06.21, Sergey Ostanevich wrote:
> Hi!
>
> Thanks for the update, LGTM.
>
> As for LuaJIT code style - should it follow the Tarantool Lua one?
> https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/ <https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/>
Not exactly -- LuaJIT prefers fake-quarter tabs (2 spaces indent level,
tab instead 8 spaces).
Same for the C style. (I can't tell that I am a big fun of it.)
I suppose that it's come from PUC-Rio Lua sources.
>
> Sergos.
>
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2021-06-04 15:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 13:27 [Tarantool-patches] [PATCH luajit 0/4] Fix LuaJIT tests on aarch64, odroid Sergey Kaplun via Tarantool-patches
2021-05-24 13:27 ` [Tarantool-patches] [PATCH luajit 1/4] ARM, ARM64, PPC: Fix TSETR fallback Sergey Kaplun via Tarantool-patches
2021-06-02 12:04 ` Sergey Ostanevich via Tarantool-patches
2021-06-04 13:12 ` Sergey Kaplun via Tarantool-patches
2021-06-04 15:33 ` Sergey Ostanevich via Tarantool-patches
2021-06-04 15:39 ` Sergey Kaplun via Tarantool-patches [this message]
2021-06-10 13:51 ` Igor Munkin via Tarantool-patches
2021-06-11 8:47 ` Sergey Kaplun via Tarantool-patches
2021-06-12 13:09 ` Sergey Kaplun via Tarantool-patches
2021-05-24 13:27 ` [Tarantool-patches] [PATCH luajit 2/4] test: add skipcond on architectures for memprof Sergey Kaplun via Tarantool-patches
2021-06-02 12:28 ` Sergey Ostanevich via Tarantool-patches
2021-06-04 13:37 ` Sergey Kaplun via Tarantool-patches
2021-06-04 15:36 ` Sergey Ostanevich via Tarantool-patches
2021-06-04 16:18 ` Sergey Kaplun via Tarantool-patches
2021-06-10 13:51 ` Igor Munkin via Tarantool-patches
2021-06-11 8:18 ` Sergey Kaplun via Tarantool-patches
2021-05-24 13:27 ` [Tarantool-patches] [PATCH luajit 3/4] ARM64: Fix xpcall() error case Sergey Kaplun via Tarantool-patches
2021-06-02 12:47 ` Sergey Ostanevich via Tarantool-patches
2021-06-04 13:45 ` Sergey Kaplun via Tarantool-patches
2021-06-10 13:51 ` Igor Munkin via Tarantool-patches
2021-05-24 13:27 ` [Tarantool-patches] [PATCH luajit 4/4] ARM64: Fix xpcall() error case (really) Sergey Kaplun via Tarantool-patches
2021-06-02 14:43 ` Sergey Ostanevich via Tarantool-patches
2021-06-04 13:56 ` Sergey Kaplun via Tarantool-patches
2021-06-10 13:52 ` Igor Munkin via Tarantool-patches
2021-06-11 8:08 ` Sergey Kaplun via Tarantool-patches
2021-06-01 11:11 ` [Tarantool-patches] [PATCH luajit 0/4] Fix LuaJIT tests on aarch64, odroid Igor Munkin via Tarantool-patches
2021-06-12 16:02 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLpJPstNugmwEjEG@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergos@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/4] ARM, ARM64, PPC: Fix TSETR fallback.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox