Re: [Tarantool-patches] [PATCH] build: add missing module for jit.dump on ARM64

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Igor,

LGTM!

On 19.05.21, Igor Munkin wrote:
> Sergey,
> 
> On 18.05.21, Sergey Kaplun wrote:
> > Igor,
> > 
> > On 17.05.21, Igor Munkin wrote:

<snipped>

> > ===================================================================
> > diff --git a/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua b/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua
> > index 72caec2f9..8ff234a12 100755
> > --- a/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua
> > +++ b/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua
> > @@ -39,6 +39,5 @@ end
> >  -- Use *all* jit.dump options, so the test can check them all.
> >  require('jit.dump').start('+tbisrmXaT')
> >  -- Tune JIT engine to make the test faster and more robust.
> > -jit.opt.start('hotloop=1')
> >  -- Record primitive loop.
> > -for _ = 1, 3 do end
> > +for _ = 1, 100 do end
> > ===================================================================
> > 
> > this test fails:
> > 
> > | $ ./test-run.py app-tap/gh-5983-jit-library-smoke-tests.test.lua
> > | ...
> > | [001] app-tap/gh-5983-jit-library-smoke-tests.test.l>                 [ fail ]
> > | [001] Test failed! Output from reject file var/rejects/app-tap/gh-5983-jit-library-smoke-tests.reject:
> > | [001] TAP version 13
> > | [001] 1..1
> > | [001] not ok - jit.dump smoke tests
> > | [001]   ---
> > | [001]   filename: /Users/tntmac07.tarantool.i/s.kaplun/tarantool/master/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua
> > | [001]   trace:
> > | [001]   - line: 0
> > | [001]     source: '@/Users/tntmac07.tarantool.i/s.kaplun/tarantool/master/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua'
> > | [001]     filename: /Users/tntmac07.tarantool.i/s.kaplun/tarantool/master/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua
> > | [001]     what: main
> > | [001]     namewhat: 
> > | [001]     src: '...er/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua'
> > | [001]   line: 0
> > | [001]   expected: '---- TRACE %d start.+---- TRACE %d IR.+---- TRACE %d mcode.+---- TRACE
> > | [001]     %d stop.+---- TRACE %d exit'
> > | [001]   got: 
> > | [001]   ...
> > | [001] # failed subtest: 1
> > 
> > What am I doing wrong?
> 
> Testing this patchset on M1. Use GNU/Linux ARM64 hosts for now.

Yep, thanks!
Checked it on odroid -- it's OK.

> 
> > 
> > > +-- Record primitive loop.
> > > +for _ = 1, 3 do end
> > > 
> > > ================================================================================
> > > 
> > > CI is green[1] now.
> > > 
> 
> <snipped>
> 
> > > 
> > > [1]: https://github.com/tarantool/tarantool/commit/18a4018
> > > 
> > > -- 
> > > Best regards,
> > > IM
> > 
> > -- 
> > Best regards,
> > Sergey Kaplun
> 
> [1]: https://lists.tarantool.org/tarantool-patches/cover.1620678384.git.imun@tarantool.org/T/#t
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun