From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] lua/log: accept symbolic logging levels
Date: Thu, 27 May 2021 13:17:57 +0300 [thread overview]
Message-ID: <YK9x1S8O95cToUE9@grain> (raw)
In-Reply-To: <20210527090431.kiki5jijygpfq7l5@tkn_work_nb>
On Thu, May 27, 2021 at 12:04:31PM +0300, Alexander Turenko wrote:
>
> > +-- Test symbolic names for loglevels
> > +_, err = pcall(log.cfg, {level='fatal'})
> > +test:ok(err == nil and log.cfg.level == 0, 'both got fatal')
>
> Now I noticed one difference from box.cfg() behaviour:
>
> | tarantool> box.cfg{log_level = 'verbose'}
> | tarantool> box.cfg.log_level
> | ---
> | - verbose
> | ...
>
> | tarantool> log = require('log')
> | tarantool> log.cfg{level = 'verbose'}
> | tarantool> log.cfg.level
> | ---
> | - 6
> | ...
>
> AFAIU, box.cfg.foo generally returns the same that a user provides in
> box.cfg({foo = <...>}), without normalization.
Well, as to me this looks somehow inconvenient and worth to implement
symbolic output for log leves I think. As a separate feature.
next prev parent reply other threads:[~2021-05-27 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 11:13 Cyrill Gorcunov via Tarantool-patches
2021-05-07 11:17 ` Cyrill Gorcunov via Tarantool-patches
2021-05-26 11:04 ` Serge Petrenko via Tarantool-patches
2021-05-26 22:04 ` Alexander Turenko via Tarantool-patches
2021-05-27 7:53 ` Cyrill Gorcunov via Tarantool-patches
2021-05-27 9:04 ` Alexander Turenko via Tarantool-patches
2021-05-27 10:17 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-06-01 12:25 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK9x1S8O95cToUE9@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua/log: accept symbolic logging levels' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox