From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] box: refactor in_promote using a guard
Date: Thu, 27 May 2021 14:02:27 +0300 [thread overview]
Message-ID: <YK98Q7YT92UdqN9W@grain> (raw)
In-Reply-To: <0ab586a8-bb17-6e18-b486-c4dd5a0de42c@tarantool.org>
On Thu, May 27, 2021 at 01:57:19PM +0300, Serge Petrenko wrote:
>
> Thanks for the review!
> I think this piece of code is unrelated to what I'm changing.
> This commit was introduced to avoid multiple additions
> of `in_promote = false;` in the next commit.
>
> The change you propose is good, but it's out of scope of this patchset IMO.
> I may change apply it though if you insist.
OK, lets leave it as is. No need for more patching.
next prev parent reply other threads:[~2021-05-27 11:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 10:39 [Tarantool-patches] [PATCH v2 0/2] fix an assertion failure in box.ctl.promote() Serge Petrenko via Tarantool-patches
2021-05-25 10:39 ` [Tarantool-patches] [PATCH v2 1/2] box: refactor in_promote using a guard Serge Petrenko via Tarantool-patches
2021-05-26 7:25 ` Cyrill Gorcunov via Tarantool-patches
2021-05-27 10:57 ` Serge Petrenko via Tarantool-patches
2021-05-27 11:02 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-05-25 10:39 ` [Tarantool-patches] [PATCH v2 2/2] box: fix an assertion failure in box.ctl.promote() Serge Petrenko via Tarantool-patches
2021-05-26 6:14 ` Cyrill Gorcunov via Tarantool-patches
2021-05-26 8:25 ` Serge Petrenko via Tarantool-patches
2021-05-26 18:46 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-27 10:53 ` Serge Petrenko via Tarantool-patches
2021-05-27 11:03 ` Cyrill Gorcunov via Tarantool-patches
2021-05-27 19:30 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-01 12:20 ` [Tarantool-patches] [PATCH v2 0/2] " Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK98Q7YT92UdqN9W@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] box: refactor in_promote using a guard' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox